bsloane1650 commented on a change in pull request #223: Daffodil 1444 schema
comp simple types
URL: https://github.com/apache/incubator-daffodil/pull/223#discussion_r289626018
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/SimpleTypes.scala
##########
@@ -586,37 +539,29 @@ abstract class SimpleTypeDefFactory(xmlArg: Node,
schemaDocumentArg: SchemaDocum
}
-final class PrimitiveSimpleTypeFactory(primitiveType: PrimitiveType,
schemaDocumentArg: => SchemaDocument)
- extends SimpleTypeFactory
- with NamedMixin {
-
- override lazy val name = diagnosticDebugName
-
- override def forElement(elementDecl: ElementDeclMixin) = primitiveType
- override def forDerivedType(derivedType: SimpleTypeDefBase) = primitiveType
-
- override lazy val namedQName = primitiveType.typeNode.globalQName
- override lazy val namespace = namedQName.namespace
- override lazy val prefix = namedQName.prefix.get
- override lazy val xml = Assert.invariantFailed("Primitive types do not have
XML")
-
- override lazy val primType = primitiveType.primType
- override lazy val schemaDocument = schemaDocumentArg
-
- /*
- * These methods don't really make sense here, but are needed by NamedMixin
- */
- override def SDE(id: String, args: Any*) = Assert.invariantFailed("Primitive
types shouldn't ever have an SDE")
- override def schemaFileLocation = Assert.invariantFailed("Primitive types
don't have a schemaFileLocation")
-}
-
-final class LocalSimpleTypeDefFactory(xmlArg: Node, schemaDocumentArg:
SchemaDocument)
- extends SimpleTypeDefFactory(xmlArg, schemaDocumentArg)
- with SimpleTypeFactory {
-
- override def forElement(elementDecl: ElementDeclMixin) = new
LocalSimpleTypeDef(xmlArg, elementDecl, this)
- override def forDerivedType(derivedType: SimpleTypeDefBase) =
Assert.invariantFailed("LocalSimpleTypes cannot be used for derived types")
-}
+//final class PrimitiveSimpleTypeFactory(primitiveType: PrimitiveType,
schemaDocumentArg: => SchemaDocument)
+// extends SimpleTypeFactory
+// with NamedMixin {
+//
+// override lazy val name = diagnosticDebugName
+//
+// // override def forElement(elementDecl: ElementDeclMixin) = primitiveType
+// // override def forDerivedType(derivedType: SimpleTypeDefBase) =
primitiveType
+//
+// override lazy val namedQName = primitiveType.typeNode.globalQName
+// override lazy val namespace = namedQName.namespace
+// override lazy val prefix = namedQName.prefix.get
+// override lazy val xml = Assert.invariantFailed("Primitive types do not
have XML")
+//
+// override lazy val primType = primitiveType.primType
+// override lazy val schemaDocument = schemaDocumentArg
+//
+// /*
+// * These methods don't really make sense here, but are needed by NamedMixin
+// */
+// override def SDE(id: String, args: Any*) =
Assert.invariantFailed("Primitive types shouldn't ever have an SDE")
+// override def schemaFileLocation = Assert.invariantFailed("Primitive types
don't have a schemaFileLocation")
+//}
Review comment:
Delete
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
