mbeckerle commented on a change in pull request #237: Fixes DAFFODIL-2142
URL: https://github.com/apache/incubator-daffodil/pull/237#discussion_r294983864
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/ModelGroup.scala
##########
@@ -83,9 +83,6 @@ object ModelGroupFactory {
val groupRefInstance = groupRefFactory.groupRef
List(groupRefInstance.asModelGroup)
}
- case <annotation>{ _* }</annotation> => Nil
- case textNode: Text => Nil
- case _: Comment => Nil
case _ => {
lexicalParent.SDE("Unrecognized construct: %s", child)
Review comment:
I think this should not be an SDE. It should be
Assert.invariantFailed("Unrecognized construct %s should be handled by
caller.".format(child)), because if the code gets here with an annotation or
comment node of XML that's not a user's problem with their schema, but a flaw
in our code (likely a mistake during maintenance).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
