bsloane1650 commented on a change in pull request #240: Add dfdlx:choiceBranchKeyRanges URL: https://github.com/apache/incubator-daffodil/pull/240#discussion_r295925216
########## File path: daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/ChoiceCombinator.scala ########## @@ -34,9 +34,10 @@ import scala.util.Failure import scala.util.Success import scala.math.BigInt import org.apache.daffodil.cookers.RepValueCooker -import org.apache.daffodil.processors.RangeBound Review comment: On second thought, the original enum proposal defined that repValues must be ints if repValueRanges was used, so this really is only an now that we have choiceBranchKeyRanges as well, so I will fix this here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
