mbeckerle commented on a change in pull request #249: Emit SDE when a type
calculator attempts to use an undefined type.
URL: https://github.com/apache/incubator-daffodil/pull/249#discussion_r297840755
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/TypeCalculator.scala
##########
@@ -429,10 +454,14 @@ object TypeCalculatorCompiler {
}
}
- def compileExpression[A <: AnyRef, B <: AnyRef](optInputTypeCalc:
Option[CompiledExpression[B]], optOutputTypeCalc:
Option[CompiledExpression[A]], srcType: NodeInfo.Kind, dstType: NodeInfo.Kind):
ExpressionTypeCalculator[A, B] = {
- val maybeInputType: Maybe[CompiledExpression[B]] =
optInputTypeCalc.map(Maybe(_)).getOrElse(Maybe.Nope)
- val maybeOutputType: Maybe[CompiledExpression[A]] =
optOutputTypeCalc.map(Maybe(_)).getOrElse(Maybe.Nope)
- new ExpressionTypeCalculator(maybeInputType, maybeOutputType, srcType,
dstType)
+ def compileExpression[A <: AnyRef, B <: AnyRef](
Review comment:
I think we have too many overloads of compileExpression at this point. No
reason to further proliferate that. Can this be called
compileTypeCalcExpression ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
