bsloane1650 commented on a change in pull request #249: Emit SDE when a type calculator attempts to use an undefined type. URL: https://github.com/apache/incubator-daffodil/pull/249#discussion_r298200784
########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/dsom/CompiledExpression1.scala ########## @@ -200,14 +205,23 @@ class DPathCompileInfo( val namespaces: scala.xml.NamespaceBinding, val path: String, override val schemaFileLocation: SchemaFileLocation, - val tunable: DaffodilTunables) + val tunable: DaffodilTunables, + @TransientParam val typeCalcMapArg: TypeCalcMap) Review comment: On second thought, there is no reason to not make this passed by-name. Even though the TransientParam is there for a different reason, spamming lazyness is still our strategy to avoid circular dependencies, and it can't hurt (much) to do so preemptivly. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
