stevedlawrence commented on a change in pull request #257: Daffodil 2165 type
calc double functions
URL: https://github.com/apache/incubator-daffodil/pull/257#discussion_r299619196
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/dpath/DPathRuntime.scala
##########
@@ -95,7 +99,7 @@ class CompiledDPath(val ops: RecipeOp*) extends Serializable
{
// in a way that is not consistent with a constant expression. Such as
trying to do
// anything with the infoset other than saving and restoring current
position in the infoset.
// Ditto trying to read a variable.
- case _: InfosetException | _: VariableException | _:
java.lang.IllegalStateException =>
+ case _: InfosetException | _: VariableException | _:
NoSuchElementException | _: java.lang.IllegalStateException =>
Review comment:
Yeah, I'd vote for changing it to an IllegalStateException like you mention,
and maybe create a new bug to find those usages and change to somethign
Daffodil specific so we don't hide actual bugs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
