mbeckerle commented on a change in pull request #257: Daffodil 2165 type calc
double functions
URL: https://github.com/apache/incubator-daffodil/pull/257#discussion_r299618703
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dpath/Expression.scala
##########
@@ -1706,6 +1754,43 @@ case class FunctionCallExpression(functionQNameString:
String, expressions: List
funcObj.setOOLAGContext(this)
funcObj
}
+
+ def lookupTypeCalculator(typeCalcName:Expression, requiresParse: Boolean,
requiresUnparse: Boolean):TypeCalculator[AnyRef, AnyRef]={
+ /*
+ * Every functions that currently uses this defines the type calculator
+ * as their first arguement.
+ * We still take the calculators name as an arguement to avoid relying on
this
+ * fact.
+ */
Review comment:
Confused by this comment. Why is the arg an Expression called typeCalcName?
Why not call it typeCalcExpr ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
