+1
Tested: - PGP, SHA256 and SHA512 match - "daffodil --version" returns 2.4.0 in the version bundled with bin.tgz and bin.zip - "sbt test" passes in source bundle. ________________________________ From: Beckerle, Mike <mbecke...@tresys.com> Sent: Wednesday, July 3, 2019 1:24:56 PM To: dev@daffodil.apache.org Subject: Re: [VOTE] Release Apache Daffodil (incubating) 2.4.0-rc1 +1 I verified Steve's PGP signature. I tested all the DFDL schemas I have access to. All work - minor additions needed of missing properties. Actually found a couple misspelled properties with new features of this release. Tested these which are generally available: bmp CSV EDIFACT geonames gif HL7 IBM4690-TLOG ISO8583 jpeg MagVar mil-std-2045 NACHA NITF PCAP png quasiXML utf8test Also tested these which are not generally available: agnosc_remedy army_drrs_lh cef disv6 gmtif iCalendar imf imf_iCalendar_cse ipfix nato-stanag-5516 uscg_ucop_lh usmtf vmf vmf_s2s ________________________________ From: Beckerle, Mike Sent: Wednesday, July 3, 2019 12:11:06 PM To: dev@daffodil.apache.org Subject: Re: [VOTE] Release Apache Daffodil (incubating) 2.4.0-rc1 Ah! yes I will correct the schema. That property isn't allowed there, and prior releases were just ignoring that. I also found a typo in a short-form property name on a related schema. So this feature is helping find bugs. ________________________________ From: Steve Lawrence <slawre...@apache.org> Sent: Wednesday, July 3, 2019 12:04:05 PM To: dev@daffodil.apache.org Subject: Re: [VOTE] Release Apache Daffodil (incubating) 2.4.0-rc1 According to the DFDL doc, escapeSchemaRef is only valid on dfdl:element and dfdl:simpleType. Is the schema just incorrect? Sounds to me like validation found an error in the schema, assuming the DFDL spec is right. - Steve On 7/3/19 12:00 PM, Beckerle, Mike wrote: > > I have tested existing schemas to be sure we haven't broken anything. > > > Alas, I have an iCalendar schema that works in 2.2.0, and 2.3.0, but fails to > compile on 2.4.0 with this diagnostic: > > > [error] Test com.mitre.iCalendar.Test_iCalendar.test_ex02 failed: > org.apache.daffodil.tdml.TDMLExceptionImpl: (Implementation: daffodil) > SchemaDefinitionError: Schema Definition Error: Error loading schema due to > org.xml.sax.SAXParseException; systemId: > file:/home/mbeckerle/FOUO/fouo-schemas/iCalendar/target/classes/com/mitre/iCalendar/xsd/iCalendar.dfdl.xsd; > lineNumber: 245; columnNumber: 74; cvc-complex-type.3.2.2: Attribute > 'dfdl:escapeSchemeRef' is not allowed to appear in element 'xs:sequence'. > [error] Schema context: > file:/home/mbeckerle/FOUO/fouo-schemas/iCalendar/target/classes/com/mitre/iCalendar/xsd/iCalendar.dfdl.xsd > Location in > file:/home/mbeckerle/FOUO/fouo-schemas/iCalendar/target/classes/com/mitre/iCalendar/xsd/iCalendar.dfdl.xsd, > took 0.082 sec > > > So my best guess is something about changes to fix validation of short form > properties is refusing to allow this property. > > > I will continue to test other schemas so we can get a list of which remain > compatible, and which do not. > > > I'm not going to vote yet. We'll see if there are other flaws with existing > schemas first. > > > > ________________________________ > From: Steve Lawrence <slawre...@apache.org> > Sent: Wednesday, July 3, 2019 9:03:45 AM > To: dev@daffodil.apache.org > Subject: [VOTE] Release Apache Daffodil (incubating) 2.4.0-rc1 > > Hi all, > > I'd like to call a vote to release Apache Daffodil (incubating) 2.4.0-rc1. > > All distribution packages, including signatures, digests, etc. can be > found at: > > https://dist.apache.org/repos/dist/dev/incubator/daffodil/2.4.0-rc1/ > > Staging artifacts can be found at: > > https://repository.apache.org/content/repositories/orgapachedaffodil-1009/ > > This release has been signed with PGP key 36F3494B033AE661, > corresponding to slawre...@apache.org, which is included in the KEYS > file here: > > https://www.apache.org/dist/incubator/daffodil/KEYS > > The release candidate has been tagged in git with v2.4.0-rc1. > > For reference, here is a list of all closed JIRAs tagged with 2.4.0: > > https://issues.apache.org/jira/browse/DAFFODIL-1477?jql=project%20%3D%20DAFFODIL%20AND%20fixVersion%20%3D%202.4.0%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC > > For a summary of the changes in this release, see: > > https://daffodil.apache.org/releases/2.4.0/ > > Please review and vote. The vote will be open for at least 72 hours > (Saturday, 6 July 2019, 9am EST). > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove (and reason why) > > Thanks, > - Steve >
