mbeckerle commented on a change in pull request #259: Incremental progress on
schema compilation space/speed issue.
URL: https://github.com/apache/incubator-daffodil/pull/259#discussion_r301238473
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/ElementBase.scala
##########
@@ -406,7 +411,7 @@ trait ElementBase
* To be properly constructed, scala's xml Elems must share the scope
(namespace bindings) of the enclosing
* parent element, except when it adds more of its own bindings, in which
case the tail is supposed to be shared.
*/
- private lazy val minimizedScope: NamespaceBinding = {
+ private lazy val minimizedScope: NamespaceBinding = LV('minimizedScope) {
Review comment:
Minimized scope isn't correct any more because a shared definition may be
reused in multiple contexts that have different enclosing sets of namespace
prefix definitions.
Really we need a table here, so we can lookup the distinct minimizedScope
for that context.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
