stevedlawrence commented on a change in pull request #259: Incremental progress
on schema compilation space/speed issue.
URL: https://github.com/apache/incubator-daffodil/pull/259#discussion_r301685826
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/dsom/CompiledExpression1.scala
##########
@@ -350,14 +321,11 @@ class DPathElementCompileInfo(
final private def writeObject(out: java.io.ObjectOutputStream): Unit =
serializeObject(out)
final lazy val rootElement: DPathElementCompileInfo =
- this.enclosingElementCompileInfo.map { _.rootElement }.getOrElse { this }
-
- final def enclosingElementPath: Seq[DPathElementCompileInfo] = {
- enclosingElementCompileInfo match {
- case None => Seq()
- case Some(e) => e.enclosingElementPath :+ e
- }
- }
+ if (elementCompileInfos.isEmpty) this
+ else if (enclosingElementCompileInfos.isEmpty) this
+ else
+ // else if (elementCompileInfos.head eq this) this
Review comment:
Remove comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
