mbeckerle commented on a change in pull request #259: Incremental progress on
schema compilation space/speed issue.
URL: https://github.com/apache/incubator-daffodil/pull/259#discussion_r301856439
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/SchemaComponent.scala
##########
@@ -200,7 +238,7 @@ trait SchemaComponent
case sgd: GlobalSequenceGroupDef => "sgd=" + sgd.namedQName
case cg: Choice => "c" + (if (cg.position > 1) cg.position else "")
case sg: Sequence => "s" + (if (sg.isHidden) "h" else "") + (if
(sg.position > 1) sg.position else "")
- case sc => Assert.invariantFailed("Unexpected component type: " + sc)
+ case unknown => "unk=" + unknown.toString()
Review comment:
SSCD strings are used in logging and printf debug-by-print statements, and
if they can fail you get stack overflows, etc. I was running into those so I
rigged this to never fail by putting this unknown case in as the stop-gap after
I found I had missed a case. (which I also added).
I will switch this back to Assert.invariantFailed now that this is debugged,
and put a more informative message in it indicating that it failed trying to
construct an SSCD for a particular object class. That will make it quick to fix
if we in fact run into it again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
