mbeckerle commented on a change in pull request #259: Incremental progress on
schema compilation space/speed issue.
URL: https://github.com/apache/incubator-daffodil/pull/259#discussion_r303192578
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/dpath/NodeInfo.scala
##########
@@ -253,16 +258,16 @@ object NodeInfo extends Enum {
* hierarchy. We have it as a parent of both complex type and simple type
since
* both of them can be nillable.
*/
- protected sealed trait NillableKind extends AnyType.Kind
- case object Nillable extends TypeNode(AnyType, List(Complex, AnySimpleType))
with NillableKind {
- type Kind = NillableKind
- }
+ // protected sealed trait NillableKind extends AnyType.Kind
Review comment:
remove commented code - several of these type taxonomy nodes have been
removed (2 or 3)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
