mbeckerle commented on a change in pull request #263: Add more obscure charsets
needed for some mil formats.
URL: https://github.com/apache/incubator-daffodil/pull/263#discussion_r312549663
##########
File path:
daffodil-io/src/main/scala/org/apache/daffodil/processors/charset/DaffodilCharsetProvider.scala
##########
@@ -25,7 +25,14 @@ object DaffodilCharsetProvider {
BitsCharset5BitPackedLSBF,
BitsCharset6BitDFI264DUI001,
BitsCharset6BitDFI311DUI002,
+ BitsCharset3BitDFI336DUI001,
+ BitsCharset4BitDFI746DUI002,
+ BitsCharset3BitDFI746DUI002,
+ BitsCharset3BitDFI747DUI001,
+ BitsCharset5BitDFI769DUI002,
Review comment:
They are sorted by the DFI number. Not the length. But given the mixture of
different encodings here, some of which are these obscure DFI/DUI things, some
of which are more understandable things, I take your point. i'll sort these
alphanumerically.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
