mbeckerle commented on a change in pull request #262: Unordered sequences
URL: https://github.com/apache/incubator-daffodil/pull/262#discussion_r318260009
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/grammar/SequenceGrammarMixin.scala
##########
@@ -135,7 +141,10 @@ trait SequenceGrammarMixin extends GrammarMixin { self:
SequenceTermBase =>
case (e: EB, Ordered__, TrailingStr, Implicit__, ___, UNB) => new
RepOrderedWithMinMaxSequenceChild(this, e, groupIndex)
case (e: EB, Ordered__, TrailingStr, Implicit__, ___, max) => new
RepOrderedWithMinMaxSequenceChild(this, e, groupIndex)
case (e: EB, Ordered__, Always_____, Implicit__, ___, max) => new
RepOrderedWithMinMaxSequenceChild(this, e, groupIndex)
- case (m: MG, Ordered__, ___________, __________, ___, __2) => new
ScalarOrderedSequenceChild(this, m, groupIndex)
+ case (e: EB, Unordered, ___________, Parsed____, ONE, ONE) => new
ScalarOrderedSequenceChild(this, e, groupIndex)
+ case (e: EB, Unordered, ___________, Parsed____, ___, max) => new
RepOrderedWithMinMaxSequenceChild(this, e, groupIndex)
+ case (e: EB, Unordered, ___________, __________, ___, __2) =>
e.SDE("When sequenceKind='unordered', occursCountKind must be 'parsed'")
Review comment:
I think the DFDL spec requires that we check for OCK 'parsed' and SDE
otherwise.
I do think there is a bug here which is
```
case (e: EB, Unordered, ___________, Parsed____, ONE, ONE)
```
Should not use the Parsed____, but a general anything wildcard, because if
min/maxOccurs are 1 1, then OCK is ignored even within a unordered sequence.
I think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
