stevedlawrence commented on a change in pull request #273: WIP: Add User Defined Functions Capability URL: https://github.com/apache/incubator-daffodil/pull/273#discussion_r331576134
########## File path: daffodil-udf/src/main/java/org/apache/daffodil/udf/UDFunctionProvider.java ########## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.daffodil.udf; + +public abstract class UDFunctionProvider { + private Class<?>[] functionClasses; + + public Class<?>[] getFunctionClasses() { + return functionClasses; + } + + public void setFunctionClasses(Class<?>[] functionClasses) { + this.functionClasses = functionClasses; + } + + public abstract Object lookupFunctionClass(String namespace, String name); Review comment: Does it make sense to provide a default lookupFunctionClass that iterates over the result of getFunctionClasses, inspects the annotation to find the right class, and calls newInstance if found? For functions that don't require state and have an empty constructor (probably most of them) this would make it easier to create a new UDFProvider. And if a provider did want to provide state to one of their functions, they could override it and manually create their new instances. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
