stevedlawrence commented on a change in pull request #276: Updated Unordered
Sequence code to better support vCard
URL: https://github.com/apache/incubator-daffodil/pull/276#discussion_r334139407
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/Parser.scala
##########
@@ -281,6 +293,10 @@ class ChoiceParser(ctxt: RuntimeData, val childParsers:
Vector[Parser])
}
pstate.popDiscriminator
+
+ if (discriminatorFailed)
+ pstate.setDiscriminator(true)
+
Review comment:
Is this setting the correct discriminator? I was originally thinking that we
would need to push a new discriminator somewhere, and then check that result
someehwere else to know when to bail on the unordered sequence. But maybe
that's not necessary and this is correct? This could maybe use a comment to
explain where the discrimnator that this is setting gets pushed onto the stack?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
