mbeckerle commented on a change in pull request #276: Updated Unordered
Sequence code to better support vCard
URL: https://github.com/apache/incubator-daffodil/pull/276#discussion_r334555772
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/Parser.scala
##########
@@ -281,6 +293,10 @@ class ChoiceParser(ctxt: RuntimeData, val childParsers:
Vector[Parser])
}
pstate.popDiscriminator
+
+ if (discriminatorFailed)
+ pstate.setDiscriminator(true)
+
Review comment:
Add comment to this setDiscriminator call pointing out that the inner choice
discriminator is now off the stack, so this is setting the discriminator of the
outer unordered sequence loop insuring that while we have two physical
discriminators (outer for the loop, inner for the choice), that this is making
it behave as if there was only a single discriminator.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
