mbeckerle commented on a change in pull request #273: WIP: Add User Defined
Functions Capability
URL: https://github.com/apache/incubator-daffodil/pull/273#discussion_r334642312
##########
File path:
daffodil-udf/src/test/java/org/badudfs/functionclasses1/StringFunctions/StringFunctionsProvider.java
##########
@@ -16,23 +16,18 @@
*/
package org.badudfs.functionclasses1.StringFunctions;
-import org.apache.daffodil.udf.*;
+import org.apache.daffodil.udf.UserDefinedFunctionProvider;
-public class StringFunctionsProvider extends UDFunctionProvider {
-
- public Object lookupFunctionClass(String namespace, String name) {
- Object functionClass = null;
-
- String nn = String.join("_", namespace, name);
+/**
+ * UDF Provider for Negative Unit test
+ *
+ * userDefinedFunctionClasses array isn't initialized
+ */
+public class StringFunctionsProvider extends UserDefinedFunctionProvider {
- switch (nn) {
- case "com.ns.badudfs.StringFunctions_replace":
- functionClass = new Replace();
- break;
- case "com.ns.badudfs.StringFunctions_funcA":
- functionClass = new FuncA();
- break;
- }
- return functionClass;
- }
+ @Override
+ public Class<?>[] getUserDefinedFunctionClasses() {
+ // TODO Auto-generated method stub
Review comment:
Remove // TODO
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
