+1 (binding) [OK] Able to build and publish locally. [OK] Unit and Integration tests passed. [OK] I was able to successfully build the daffodil-vscode Scala debugger using a locally published version of daffodil (3.4.0). [OK] I was also able to take said debugger to debug and run schemas in vscode.
One issue (possibly very specific to me): - While testing I had two issues getting the code compiled because of the typedefs for "stack_t" and "strtonum". This was on macOS, the errors were that these types were already defined in another header file but it seemed to be something dealing with the macOS developer platform so should only be macOS affected and was fixed easily by commenting them out in the macOS defined areas. But I don't think it should hold up this release. Maybe if remapping these to something like "dfdl_stack_t" and "dfdl_strtonum" to avoid the error would be nice. On 2022/11/02 22:23:50 Steve Lawrence wrote: > Hi all, > > I'd like to call a vote to release Apache Daffodil 3.4.0-rc2. > > All distribution packages, including signatures, digests, etc. can be > found at: > > https://dist.apache.org/repos/dist/dev/daffodil/3.4.0-rc2/ > > Staging artifacts can be found at: > > https://repository.apache.org/content/repositories/orgapachedaffodil-1032/ > > This release has been signed with PGP key 36F3494B033AE661, > corresponding to slawre...@apache.org, which is included in the KEYS > file here: > > https://downloads.apache.org/daffodil/KEYS > > The release candidate has been tagged in git with v3.4.0-rc2. > > For reference, here is a list of all closed JIRAs tagged with 3.4.0: > > https://s.apache.org/daffodil-issues-3.4.0 > > For a summary of the changes in this release, see: > > https://daffodil.apache.org/releases/3.4.0/ > > Please review and vote. The vote will be open for at least 72 hours > (Monday, 7 November 2022, 18:30 EDT). > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove (and reason why) > > Thanks, > - Steve >
