+1 (binding)
Found a few minor things that I don't think should block the release, but
should be fixed in the next release.
I checked:
[OK] signature of git tag verifies
[OK] hashes and signatures of source and helper binaries are correct
[OK] source and helper binaries are 100% reproducible
[OK] source release matches git tag
[OK] source compiles using yarn package
[OK] tests pass using yarn test
[MINOR] All nightly tests pass
- Nightly tests currently fail, looks to be macOS issues
[MINOR] source and helper binary include correct LICENSE/NOTICE
- The NOTICE file copyright says 2023
[OK] RAT check passes
[OK] no unexpected binaries in source
[OK] vsix installs and runs with run with basic usage
[MINOR] no open CVEs found using sbt dependencyCheck and yarn audit
- yarn audit shows CVEs for svelte and brace-exansion, known issue or not
critical
[OK] Page for release candidate published on website
On 2025-06-18 02:22 PM, Shane Dell wrote:
Hello all,
I'd like to call a vote to release Apache Daffodil™ Extension for Visual
Studio Code 1.4.1-rc2.
All distribution packages, including signatures, digests, etc. can be
found at:
https://dist.apache.org/repos/dist/dev/daffodil/daffodil-vscode/1.4.1-rc2
This release has been signed with PGP key
86DDE7B41291E380237934F007570D3ADC76D51B, corresponding
to shaned...@apache.org, which is included in the KEYS file here:
https://downloads.apache.org/daffodil/KEYS
The release candidate has been tagged in git with 1.4.1-rc2.
For reference, here is a list of all closed GitHub issues tagged with 1.4.1:
https://github.com/apache/daffodil-vscode/milestone/11?closed=1
NOTE: Currently there is a CVE for svelte, however this will not be addressed
in 1.4.1 as upgrading svelte from 3.x to 4.x causes the code to break. This
is the same when going from svelete 3.x or 4.x to 5.x. Upgrading svelte is
planned for either 1.4.2 or 1.5.0.
Please review and vote. The vote will be open for at least 72 hours
(Monday, 23 June 2025, 2:30pm EST).
[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove (and reason why)
Documentation for 1.4.1 can be found here
https://github.com/apache/daffodil-vscode/wiki/Apache-Daffodil%E2%84%A2-Extension-for-Visual-Studio-Code:-v1.4.1.
Thank you,
- Shane Dell
