[ 
https://issues.apache.org/jira/browse/DATAFU-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16910737#comment-16910737
 ] 

Matthew Hayes commented on DATAFU-128:
--------------------------------------

Thanks Eyal!  This looks good so far.  Below are some comments.  By the way I 
think you could open a RB now.  Supposedly it was fixed.

*README.md*
 * typo: modules's

*site/source/index.markdown.erb*
 * Missing asterisk after DataFu Spark

*General comments*

I think the getting started page for Spark should mention something about how 
make Spark use the downloaded JAR.  The example assumes you already know how to 
do this.  Also the Spark Guide is pretty short.  I'm assuming you probably 
intend to write more there :)

> Add documentation for macros
> ----------------------------
>
>                 Key: DATAFU-128
>                 URL: https://issues.apache.org/jira/browse/DATAFU-128
>             Project: DataFu
>          Issue Type: Improvement
>            Reporter: Eyal Allweil
>            Assignee: Eyal Allweil
>            Priority: Major
>         Attachments: DATAFU-128.patch
>
>
> Now that it is possible to [add Pig macros to 
> Datafu|https://issues.apache.org/jira/browse/DATAFU-123], we should update 
> the documentation to reflect this, and provide guidelines and point would-be 
> contributors to examples.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to