----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23751/#review49482 -----------------------------------------------------------
datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java <https://reviews.apache.org/r/23751/#comment86548> You might consider checking each case individually. Otherwise when the data doesn't match it is hard to identify where the problem is. For example, here is the test failure output I currently see: junit.framework.ComparisonFailure: null expected:<...tp,/eng/hello.jsp,,[[x#foo,y#bar])) ((world.org,hello.world.org,http,/products/data/data.html,90,)) ((bar.com,roger.bar.com,http,/eng/hello.jsp,,[x#foo,y#bar]]))> but was:<...tp,/eng/hello.jsp,,[[y#bar,x#foo])) ((world.org,hello.world.org,http,/products/data/data.html,90,)) ((bar.com,roger.bar.com,http,/eng/hello.jsp,,[y#bar,x#foo]]))> - Matthew Hayes On Aug. 4, 2014, 6:34 p.m., Joydeep Banerjee wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23751/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2014, 6:34 p.m.) > > > Review request for DataFu. > > > Repository: datafu > > > Description > ------- > > DATAFU-62 - Pig UDF for URL info > > > Diffs > ----- > > datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION > datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/23751/diff/ > > > Testing > ------- > > > Thanks, > > Joydeep Banerjee > >
