----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23384/#review51341 -----------------------------------------------------------
Sorry for the delay in reviewing your updated version. I only see doc issues at this point. I still haven't looked through the numerical range code yet though. I'll do that next. datafu-pig/src/main/java/datafu/pig/stats/Ndcg.java <https://reviews.apache.org/r/23384/#comment89548> Probably should rephrase this to "on a bag of item scores" datafu-pig/src/main/java/datafu/pig/stats/Ndcg.java <https://reviews.apache.org/r/23384/#comment89543> This should be an <a> tag right? datafu-pig/src/main/java/datafu/pig/stats/Ndcg.java <https://reviews.apache.org/r/23384/#comment89546> Document that when called with no arguments log2 will be used. datafu-pig/src/main/java/datafu/pig/stats/Ndcg.java <https://reviews.apache.org/r/23384/#comment89545> Define what the formula is and make it clear this gives more weight to the relevance score compared to log2. datafu-pig/src/main/java/datafu/pig/stats/Ndcg.java <https://reviews.apache.org/r/23384/#comment89544> Extra period in doc datafu-pig/src/main/java/datafu/pig/stats/Ndcg.java <https://reviews.apache.org/r/23384/#comment89547> You should document what the input to NDCG is (i.e. a bag of scores). See earlier comment. The example could reinforce this like so: FOREACH replayExamples GENERATE NDCG(documents.(score)); - Matthew Hayes On July 21, 2014, 5:06 p.m., Joshua Hartman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23384/ > ----------------------------------------------------------- > > (Updated July 21, 2014, 5:06 p.m.) > > > Review request for DataFu and Matthew Hayes. > > > Repository: datafu > > > Description > ------- > > DATAFU-60 Support for NDCG > > > Diffs > ----- > > > datafu-pig/src/main/java/datafu/pig/stats/ExponentialWeightedLog2ScoringFunction.java > PRE-CREATION > datafu-pig/src/main/java/datafu/pig/stats/Log2ScoringFunction.java > PRE-CREATION > datafu-pig/src/main/java/datafu/pig/stats/Ndcg.java PRE-CREATION > datafu-pig/src/main/java/datafu/pig/stats/PositionScoringFunction.java > PRE-CREATION > datafu-pig/src/main/java/datafu/pig/stats/RangeScoringFunction.java > PRE-CREATION > datafu-pig/src/main/java/datafu/pig/stats/UnaryScoringFunction.java > PRE-CREATION > datafu-pig/src/main/java/datafu/pig/util/NumericalRange.java PRE-CREATION > datafu-pig/src/main/java/datafu/pig/util/RangeMap.java PRE-CREATION > datafu-pig/src/test/java/datafu/test/pig/stats/NdcgTests.java PRE-CREATION > datafu-pig/src/test/java/datafu/test/pig/util/TestRange.java PRE-CREATION > datafu-pig/src/test/java/datafu/test/pig/util/TestRangeMap.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/23384/diff/ > > > Testing > ------- > > Unit tests, Pig tests attached > > > Thanks, > > Joshua Hartman > >
