----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25428/ -----------------------------------------------------------
Review request for DataFu. Bugs: DATAFU-68 https://issues.apache.org/jira/browse/DATAFU-68 Repository: datafu Description ------- Attaching patch that: * Fixes trailing whitespaces in the file * Adds validation that signature is not null before calling hashCode * Added check to intToRandomDouble to ensure that we won't use the null Diffs ----- datafu-pig/src/main/java/datafu/pig/sampling/SampleByKey.java d94a038 Diff: https://reviews.apache.org/r/25428/diff/ Testing ------- I didn't add new test case as I wasn't able to easily force Pig to call the method setUDFContextSignature with null parameter on the unit test level. Existing unit tests are passing. Thanks, Jarek Cecho