+1, non-binding. On Mon, Jul 15, 2024 at 11:07 AM Mehmet Ozan Kabak <o...@synnada.ai> wrote:
> +1 > > > On Jul 14, 2024, at 7:55 PM, tison <wander4...@gmail.com> wrote: > > > > +1 non-binding > > > > LGTM > > > > Best, > > tison. > > > > > > Edmondo Porcu <edmondo.po...@gmail.com>于2024年7月14日 周日08:31写道： > > > >> +1 (non-binding) > >> > >> > >> I was starting to work on a contribution to make it possible to produce > >> indented SQL using `unparser(expr).to_string()` and I realized that > >> `ast::Statement` lives in sql-parser. I think keeping the SQL parsing > code > >> under the Datafusion umbrella could help development of features that > are > >> accessed via DataFusion API but relate to code living in sqlparser > >> > >> Edmondo > >> > >> > >> > >> > >> > >> Il giorno lun 8 lug 2024 alle ore 18:09 Andy Grove > >> <andy.gr...@apple.com.invalid> ha scritto: > >> > >>> Hi, > >>> > >>> We have been discussing moving the sqlparser-rs project [1] under ASF > >>> governance for some time now. > >>> > >>> The conversation started within the Apache Arrow project before > >> DataFusion > >>> became a top-level project [2]. > >>> > >>> There is also a discussion within the sqlparser-rs community [3]. > >>> > >>> Feedback so far seems positive overall. > >>> > >>> I believe that it is now time to move to a formal vote on this within > the > >>> Apache DataFusion project. > >>> > >>> If the vote passes, the PMC and the sqlparser-rs community will work > >>> together to complete the ASF IP clearance process and push the contents > >> of > >>> the existing sqlparser/sqlparser-rs repository into a new > >>> apache/datafusion-sqlparser repository. > >>> > >>> [ ] + 1 : Accept contribution of sqlparser-rs repository > >>> [ ] 0 : No opinion > >>> [ ] -1 : Reject contribution because …. > >>> > >>> Here is my vote: > >>> > >>> +1 > >>> > >>> Thanks, > >>> > >>> Andy. > >>> > >>> [1] https://github.com/sqlparser-rs/sqlparser-rs > >>> > >>> [2] https://lists.apache.org/thread/q80j49poyg99x2c01900312qz7ps9wgp > >>> > >>> [3] https://github.com/sqlparser-rs/sqlparser-rs/issues/1294 > >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@datafusion.apache.org > For additional commands, e-mail: dev-h...@datafusion.apache.org > >
