Thanks, Tim. I cherry picked your PR to branch 43.0.0 and will create a new RC
tomorrow.
This vote is now canceled.
> On Dec 3, 2024, at 5:26 AM, Tim Saucer <timsau...@gmail.com> wrote:
>
> -1 (non-binding)
>
> When I ran the `datafusion-python` tests they all went fine. After that I
> have a set of unit tests in my own repository for internal work and ran
> into two issues:
>
> 1) Now that built in window functions are being removed, calling things
> like `datafusion.functions.window("lead", ..)` no longer work. They *will*
> work if you pass in the session context.
> 2) When you do pass in a session context to the `window` function you are
> passing the wrapper and not the internal PySessionContext.
>
> I will put up a PR today to resolve both issues.
>
> I had some other failures and I'll continue to track them down.
>
>
> On Mon, Dec 2, 2024 at 8:15 PM Andy Grove <andygrov...@gmail.com> wrote:
>
>> Hi,
>>
>> I would like to propose a release of the Apache DataFusion Python Bindings,
>> version 43.0.0.
>>
>> This release candidate is based on commit:
>> 09b2f490e774339e1a00f9c620f7374916f3898e [1]
>> The proposed release tarball and signatures are hosted at [2].
>> The changelog is located at [3].
>> The Python wheels are located at [4].
>>
>> Please download, verify checksums and signatures, run the unit tests, and
>> vote
>> on the release. The vote will be open for at least 72 hours.
>>
>> Only votes from PMC members are binding, but all members of the community
>> are
>> encouraged to test the release and vote with "(non-binding)".
>>
>> The standard verification procedure is documented at
>>
>> https://github.com/apache/datafusion-python/blob/main/dev/release/README.md#verifying-release-candidates
>> .
>>
>> [ ] +1 Release this as Apache DataFusion Python 43.0.0
>> [ ] +0
>> [ ] -1 Do not release this as Apache DataFusion Python 43.0.0 because...
>>
>> Here is my vote:
>>
>> +1
>>
>> [1]:
>>
>> https://github.com/apache/datafusion-python/tree/09b2f490e774339e1a00f9c620f7374916f3898e
>> [2]:
>>
>> https://dist.apache.org/repos/dist/dev/datafusion/apache-datafusion-python-43.0.0-rc1
>> [3]:
>>
>> https://github.com/apache/datafusion-python/blob/09b2f490e774339e1a00f9c620f7374916f3898e/CHANGELOG.md
>> [4]: https://test.pypi.org/project/datafusion/43.0.0/
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@datafusion.apache.org
For additional commands, e-mail: dev-h...@datafusion.apache.org
