There are a few format issues while running `verify-release-candidate.sh`:
```
+ cargo fmt --all -- --check
Diff in
/private/var/folders/26/jr5lms716817rm8_wsr3w7n80000gn/T/datafusion-sqlparser-rs-0.53.0.XXXXX.JaesmyIQIo/apache-datafusion-sqlparser-rs-0.53.0/derive/src/lib.rs:18:
use proc_macro2::TokenStream;
use quote::{format_ident, quote, quote_spanned, ToTokens};
use syn::spanned::Spanned;
-use syn::{parse::{Parse, ParseStream}, parse_macro_input,
parse_quote, Attribute, Data, DeriveInput, Fields, GenericParam,
Generics, Ident, Index, LitStr, Meta, Token, Type, TypePath};
+use syn::{
+ parse::{Parse, ParseStream},
+ parse_macro_input, parse_quote, Attribute, Data, DeriveInput,
Fields, GenericParam, Generics,
+ Ident, Index, LitStr, Meta, Token, Type, TypePath,
+};
use syn::{Path, PathArguments};
/// Implementation of `[#derive(Visit)]`
Diff in
/private/var/folders/26/jr5lms716817rm8_wsr3w7n80000gn/T/datafusion-sqlparser-rs-0.53.0.XXXXX.JaesmyIQIo/apache-datafusion-sqlparser-rs-0.53.0/derive/src/lib.rs:267:
}
fn is_option(ty: &Type) -> bool {
- if let Type::Path(TypePath { path: Path { segments, .. }, .. }) = ty {
+ if let Type::Path(TypePath {
+ path: Path { segments, .. },
+ ..
+ }) = ty
+ {
if let Some(segment) = segments.last() {
if segment.ident == "Option" {
if let PathArguments::AngleBracketed(args) =
&segment.arguments {
```
On Thu, Dec 12, 2024 at 6:52 AM Andrew Lamb <al...@influxdata.com> wrote:
>
> Hi,
>
> I would like to propose a release of Apache DataFusion sqlparser-rs version
> 0.53.0.
>
> Notes:
> 1. This is RC2 (RC1 hit [6])
> 2. there is a known, but I don't think blocking, issue with the
> verification script[7]
>
> This release candidate is based on commit:
> e7d2c852918fe273a4f13288eae3c95cc99dff30 [1]
> The proposed release tarball and signatures are hosted at [2].
> The changelog is located at [3].
>
> Note this release was built from branch-0.53[4], not main, which adds
> 1. the ASF license header to a newly added file (spans.rs)[5]
> 2. runs cargo fmt on derive [6]
>
> Please download, verify checksums and signatures, run the unit tests, and
> vote
> on the release. The vote will be open for at least 72 hours.
>
> Only votes from PMC members are binding, but all members of the community
> are
> encouraged to test the release and vote with "(non-binding)".
>
> The standard verification procedure is documented at
> https://github.com/apache/datafusion-sqlparser-rs/blob/main/dev/release/README.md#verifying-release-candidates
> .
>
> [ ] +1 Release this as Apache DataFusion sqlparser-rs 0.53.0
> [ ] +0
> [ ] -1 Do not release this as Apache DataFusion sqlparser-rs 0.53.0
> because...
>
> Here is my vote:
>
> +1
>
> [1]:
> https://github.com/apache/datafusion-sqlparser-rs/tree/e7d2c852918fe273a4f13288eae3c95cc99dff30
> [2]:
> https://dist.apache.org/repos/dist/dev/datafusion/apache-datafusion-sqlparser-rs-0.53.0-rc2
> [3]:
> https://github.com/apache/datafusion-sqlparser-rs/blob/e7d2c852918fe273a4f13288eae3c95cc99dff30/CHANGELOG.md
>
> [4]: https://github.com/apache/datafusion-sqlparser-rs/tree/branch-0.53
> [5]: https://github.com/apache/datafusion-sqlparser-rs/pull/1594
> [6]: https://github.com/apache/datafusion-sqlparser-rs/pull/1595
> [7]: https://github.com/apache/datafusion-sqlparser-rs/issues/1596
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@datafusion.apache.org
For additional commands, e-mail: dev-h...@datafusion.apache.org
