+1 (non-binding) Thanks for running this release!

I was able to run the verification script successfully on M1 Mac.
```
./dev/release/verify-release-candidate.sh 45.2.0 2
```

I also verified by running pytest directly, based on
https://github.com/apache/datafusion-python/blob/main/dev/release/README.md#verifying-a-release,
after downgrading to `pyarrow==18.0.0`
```
git fetch --tags
git checkout 45.2.0-rc2
git submodule update --init --recursive
python3 -m venv .venv
source .venv/bin/activate
pip install --extra-index-url https://test.pypi.org/simple/
 datafusion==45.2.0
pip install pytest
pip install pyarrow==18.0.0
pytest --import-mode=importlib python/tests
```

For context, here's the error I encountered using `pyarrow=19.0.0`,
https://gist.github.com/kevinjqliu/6d111bf7bd74c165c34e4366fe53a6c6.
Looks like we don't pin a specific pyarrow version, so when the new version
(`19.0.1`) is released next week, the issue should be automatically
resolved.

Best,
Kevin Liu

On Mon, Feb 17, 2025 at 3:32 PM L. C. Hsieh <vii...@gmail.com> wrote:

> +1 (binding)
>
> Verified on M4 Mac.
>
> Thanks Tim.
>
> On Mon, Feb 17, 2025 at 3:15 PM Tim Saucer <timsau...@gmail.com> wrote:
> >
> > Hi,
> >
> > I would like to propose a release of the Apache DataFusion Python
> Bindings,
> > version 45.2.0.
> >
> > I have two special notes for this release
> > - The version is 45.2.0 due to changes I needed to make during release
> > candidate testing prior to submitting this for a vote. I would like to
> > revisit next release how we compose release candidates to prevent these
> > minor version numbers from diverging too far from the upstream DataFusion
> > repository.
> > - There is currently a bug in pyarrow-19.0.0. This is a known issue
> > described at [5] that will be updated very soon. When running the
> > validation you will need to do an additional step of `pip install
> > pyarrow==18.0.0` to downgrade pyarrow.
> >
> > This release candidate is based on commit:
> > 639e2abc9ce1e7753f9779c7496da799a32c54a5 [1]
> > The proposed release tarball and signatures are hosted at [2].
> > The changelog is located at [3].
> > The Python wheels are located at [4].
> >
> > Please download, verify checksums and signatures, run the unit tests, and
> > vote
> > on the release. The vote will be open for at least 72 hours.
> >
> > Only votes from PMC members are binding, but all members of the community
> > are
> > encouraged to test the release and vote with "(non-binding)".
> >
> > The standard verification procedure is documented at
> >
> https://github.com/apache/datafusion-python/blob/main/dev/release/README.md#verifying-release-candidates
> > .
> >
> > [ ] +1 Release this as Apache DataFusion Python 45.2.0
> > [ ] +0
> > [ ] -1 Do not release this as Apache DataFusion Python 45.2.0 because...
> >
> > Here is my vote:
> >
> > +1 (non-binding)
> >
> > [1]:
> >
> https://github.com/apache/datafusion-python/tree/639e2abc9ce1e7753f9779c7496da799a32c54a5
> > [2]:
> >
> https://dist.apache.org/repos/dist/dev/datafusion/apache-datafusion-python-45.2.0-rc2
> > [3]:
> >
> https://github.com/apache/datafusion-python/blob/639e2abc9ce1e7753f9779c7496da799a32c54a5/CHANGELOG.md
> > [4]: https://test.pypi.org/project/datafusion/45.2.0/
> > [5]:
> >
> https://arrow.apache.org/blog/2025/01/16/19.0.0-release/#release-highlights
> > ---------------------------------------------------------
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@datafusion.apache.org
> For additional commands, e-mail: dev-h...@datafusion.apache.org
>
>

Reply via email to