Update: we have merged a fix for the scripts [1] I suggest we make a new RC with the fix and start a new voting thread
[1]: https://github.com/apache/datafusion/pull/14990 On Mon, Mar 3, 2025 at 12:15 PM Andy Grove <andygrov...@gmail.com> wrote: > I have a PR that may fix the issue: > https://github.com/apache/datafusion/pull/14985 > > On Mon, Mar 3, 2025 at 10:04 AM Andrew Lamb <andrewlam...@gmail.com> > wrote: > > > I think something in rustup changed: > > > https://github.com/apache/datafusion/issues/14982#issuecomment-2694821546 > > > > On Mon, Mar 3, 2025 at 11:58 AM Andy Grove <andygrov...@gmail.com> > wrote: > > > > > I am seeing similar errors today on all Comet PRs. Something seems to > > have > > > changed with the 1.85 release. For Comet, changing the rust-toolchain > > file > > > to refer to channel "stable" rather than a specific version number > seems > > to > > > fix this. > > > > > > On Mon, Mar 3, 2025 at 9:25 AM Andrew Lamb <al...@influxdata.com> > wrote: > > > > > > > I have a PR with a workaround for the release verification issue[1]. > > > > > > > > However, I am not sure if there is a problem with the script or if > the > > > > issue is with rustup. > > > > > > > > Perhaps for now to unblock the release, we can merge [1] and make RC2 > > > > > > > > Andrew > > > > > > > > [1] https://github.com/apache/datafusion/pull/14983 > > > > > > > > On Mon, Mar 3, 2025 at 10:44 AM Andrew Lamb <andrewlam...@gmail.com> > > > > wrote: > > > > > > > > > Thanks Xudong! > > > > > > > > > > I ran the verification script > > > > > ``` > > > > > $ ./dev/release/verify-release-candidate.sh 46.0.0 1 > > > > > ``` > > > > > > > > > > And it errored in the following way: > > > > > > > > > > ``` > > > > > error: toolchain '1.85.0-aarch64-apple-darwin' is not installed > > > > > help: run `rustup toolchain install 1.85.0-aarch64-apple-darwin` to > > > > install > > > > > it > > > > > + cleanup > > > > > + '[' no = yes ']' > > > > > + echo 'Failed to verify release candidate. See > > > > > > > > > > > > > > > > > > > > /var/folders/1l/tg68jc6550gg8xqf1hr4mlwr0000gn/T/datafusion-46.0.0.XXXXX.ps1ExCTVRs > > > > > for details.' > > > > > Failed to verify release candidate. See > > > > > > > > > > > > > > > > > > > > /var/folders/1l/tg68jc6550gg8xqf1hr4mlwr0000gn/T/datafusion-46.0.0.XXXXX.ps1ExCTVRs > > > > > for details. > > > > > ``` > > > > > > > > > > It is not clear to me what is going on and this seems to have > started > > > > > happening on CI on main too. > > > > > > > > > > I filed a ticket to track[1] > > > > > > > > > > [1]: https://github.com/apache/datafusion/issues/14982 > > > > > > > > > > On Mon, Mar 3, 2025 at 8:44 AM Wang Xudong <wxd963996...@gmail.com > > > > > > wrote: > > > > > > > > > > > Hi, > > > > > > > > > > > > I would like to propose a release of Apache DataFusion version > > > 46.0.0. > > > > > > > > > > > > This release candidate is based on commit: > > > > > > ec4862fa2d870fcab973fd1589ef99b6bf8d560f [1] > > > > > > The proposed release tarball and signatures are hosted at [2]. > > > > > > The changelog is located at [3]. > > > > > > > > > > > > Please download, verify checksums and signatures, run the unit > > tests, > > > > and > > > > > > vote > > > > > > on the release. The vote will be open for at least 72 hours. > > > > > > > > > > > > Only votes from PMC members are binding, but all members of the > > > > community > > > > > > are > > > > > > encouraged to test the release and vote with "(non-binding)". > > > > > > > > > > > > The standard verification procedure is documented at > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/datafusion/blob/main/dev/release/README.md#verifying-release-candidates > > > > > > . > > > > > > > > > > > > [ ] +1 Release this as Apache DataFusion 46.0.0 > > > > > > [ ] +0 > > > > > > [ ] -1 Do not release this as Apache DataFusion 46.0.0 because... > > > > > > > > > > > > Here is my vote: > > > > > > > > > > > > +1 (non binding) > > > > > > > > > > > > [1]: > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/datafusion/tree/ec4862fa2d870fcab973fd1589ef99b6bf8d560f > > > > > > [2]: > > > > > > > > > > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/datafusion/apache-datafusion-46.0.0-rc1 > > > > > > [3]: > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/datafusion/blob/ec4862fa2d870fcab973fd1589ef99b6bf8d560f/CHANGELOG.md > > > > > > > > > > > > > > > > > > > > >
