Oops. Thanks, Xudong! On Tue, Mar 4, 2025 at 3:38 PM Andy Grove <andygrov...@gmail.com> wrote:
> +1 (binding) > > Tested with verification script and with Comet upgrade. > > Thanks, Andrew! > > > On Tue, Mar 4, 2025 at 11:22 AM Kevin Liu <kevinjq...@apache.org> wrote: > >> Thank you, that fixed the issue. >> >> +1 (non-binding). >> Verified by running `./dev/release/verify-release-candidate.sh 46.0.0 2` >> on >> M1 Mac. >> >> Best, >> Kevin Liu >> >> >> On Tue, Mar 4, 2025 at 8:48 AM Andrew Lamb <al...@influxdata.com> wrote: >> >> > I think you need to set the limit of files higher. Something like the >> > following >> > >> > ``` >> > ulimit -n 10000 >> > ``` >> > >> > We discussed this on a ticket previously[1]. Maybe we should fix it for >> > real :thinking: >> > >> > [1] https://github.com/apache/datafusion/issues/10674 >> > >> > >> > >> > On Tue, Mar 4, 2025 at 11:30 AM Kevin Liu <kevinjq...@apache.org> >> wrote: >> > >> > > Hey folks, >> > > >> > > I'm having issues with one particular test. It could be my local >> > machine. I >> > > tried restarting my laptop and running the test in isolation (`cargo >> test >> > > -p datafusion --test fuzz`) but the error still persists. >> > > >> > > ``` >> > > ./dev/release/verify-release-candidate.sh 46.0.0 2 >> > > >> > > failures: >> > > >> > > ---- fuzz_cases::sort_fuzz::test_sort_10k_mem stdout ---- >> > > >> > > thread 'fuzz_cases::sort_fuzz::test_sort_10k_mem' panicked at >> > > datafusion/core/tests/fuzz_cases/sort_fuzz.rs:272:63: >> > > called `Result::unwrap()` on an `Err` value: Execution("Failed to >> create >> > > partition file at >> > > >> > >> \"/var/folders/f1/3_vzsn7x1jq9hszb3z9y6f0m0000gn/T/.tmpYjVAvj/.tmph79STL\": >> > > Os { code: 24, kind: Uncategorized, message: \"Too many open files\" >> }") >> > > note: run with `RUST_BACKTRACE=1` environment variable to display a >> > > backtrace >> > > >> > > >> > > failures: >> > > fuzz_cases::sort_fuzz::test_sort_10k_mem >> > > >> > > test result: FAILED. 64 passed; 1 failed; 0 ignored; 0 measured; 0 >> > filtered >> > > out; finished in 74.07s >> > > ``` >> > > >> > > Best, >> > > Kevin Liu >> > > >> > > On Tue, Mar 4, 2025 at 7:21 AM L. C. Hsieh <vii...@gmail.com> wrote: >> > > >> > > > +1 (binding) >> > > > >> > > > Verified on M4 Mac. >> > > > >> > > > Thanks Xudong. >> > > > >> > > > On Tue, Mar 4, 2025 at 7:02 AM Andrew Lamb <al...@influxdata.com> >> > wrote: >> > > > > >> > > > > +1 (binding) >> > > > > >> > > > > I ran the verification script on an M3 mac. Thank you so much >> Xudong! >> > > > > >> > > > > Andrew >> > > > > >> > > > > On Tue, Mar 4, 2025 at 9:47 AM Wang Xudong < >> wxd963996...@gmail.com> >> > > > wrote: >> > > > > >> > > > > > Hi, >> > > > > > >> > > > > > I would like to propose a release of Apache DataFusion version >> > > 46.0.0. >> > > > > > >> > > > > > This release candidate is based on commit: >> > > > > > d5ca8307940c1a6345419a2c8d91ef87704659be [1] >> > > > > > The proposed release tarball and signatures are hosted at [2]. >> > > > > > The changelog is located at [3]. >> > > > > > >> > > > > > Please download, verify checksums and signatures, run the unit >> > tests, >> > > > and >> > > > > > vote >> > > > > > on the release. The vote will be open for at least 72 hours. >> > > > > > >> > > > > > Only votes from PMC members are binding, but all members of the >> > > > community >> > > > > > are >> > > > > > encouraged to test the release and vote with "(non-binding)". >> > > > > > >> > > > > > The standard verification procedure is documented at >> > > > > > >> > > > > > >> > > > >> > > >> > >> https://github.com/apache/datafusion/blob/main/dev/release/README.md#verifying-release-candidates >> > > > > > . >> > > > > > >> > > > > > [ ] +1 Release this as Apache DataFusion 46.0.0 >> > > > > > [ ] +0 >> > > > > > [ ] -1 Do not release this as Apache DataFusion 46.0.0 >> because... >> > > > > > >> > > > > > Here is my vote: >> > > > > > >> > > > > > +1 >> > > > > > >> > > > > > [1]: >> > > > > > >> > > > > > >> > > > >> > > >> > >> https://github.com/apache/datafusion/tree/d5ca8307940c1a6345419a2c8d91ef87704659be >> > > > > > [2]: >> > > > > > >> > > > > > >> > > > >> > > >> > >> https://dist.apache.org/repos/dist/dev/datafusion/apache-datafusion-46.0.0-rc2 >> > > > > > [3]: >> > > > > > >> > > > > > >> > > > >> > > >> > >> https://github.com/apache/datafusion/blob/d5ca8307940c1a6345419a2c8d91ef87704659be/CHANGELOG.md >> > > > > > >> > > > >> > > > >> --------------------------------------------------------------------- >> > > > To unsubscribe, e-mail: dev-unsubscr...@datafusion.apache.org >> > > > For additional commands, e-mail: dev-h...@datafusion.apache.org >> > > > >> > > > >> > > >> > >> >
