+1 (non-binding) verified in Mac M3
Thanks Tim! El vie, 10 abr 2026 a las 22:57, Tim Saucer (<[email protected]>) escribió: > Ok, I think I've solved the issue with the windows verification script and > I have PR up for it. > > It looks like this is for the case of using gnu linker + debug build and > the number of symbols. This does not happen in CI for our release builds > and does not happen on the msvc linker. I have a PR up for the verification > tool. I don't think this is a release blocker. > > On Fri, Apr 10, 2026 at 9:13 AM Andrew Lamb <[email protected]> wrote: > > > +1 (binding) > > > > Thanks Time. > > > > The windows release verification failure seems to be related to the final > > link. For example > > > > > https://github.com/apache/datafusion-python/actions/runs/24194281277/job/70626200231 > > > > = note: some arguments are omitted. use `--verbose` to show all linker > > arguments > > = note: > > > > > C:/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/15.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: > > error: export ordinal too large: 368820 > > collect2.exe: error: ld returned 1 exit status > > > > The interwebs suggest that this happens when windows DLLs try to export > > more than 65k symbols > > > > So I am not sure it is a runner issue but some real build problem (aka it > > isn't going to succeed on rerun) > > > > That being said I think it is fine to release binaries other than for > > windows and sort it out afterwards in a follow on release > > > > Andrew > > > > On Thu, Apr 9, 2026 at 9:00 PM L. C. Hsieh <[email protected]> wrote: > > > > > +1 (binding) > > > > > > Verified on Intel Mac. > > > > > > Thanks Tim. > > > > > > > > > On Thu, Apr 9, 2026 at 8:12 AM Tim Saucer <[email protected]> wrote: > > > > > > > Hi, > > > > > > > > I would like to propose a release of the Apache DataFusion Python > > > Bindings, > > > > version 53.0.0. > > > > > > > > This release candidate is based on commit: > > > > af383af369ec442e3b88841df3ba791b3a383413 [1] > > > > The proposed release tarball and signatures are hosted at [2]. > > > > The changelog is located at [3]. > > > > The Python wheels are located at [4]. > > > > > > > > Please download, verify checksums and signatures, run the unit tests, > > and > > > > vote > > > > on the release. The vote will be open for at least 72 hours. > > > > > > > > Only votes from PMC members are binding, but all members of the > > community > > > > are > > > > encouraged to test the release and vote with "(non-binding)". > > > > > > > > The standard verification procedure is documented at > > > > > > > > > > > > > > https://github.com/apache/datafusion-python/blob/main/dev/release/README.md#verifying-release-candidates > > > > . > > > > > > > > [ ] +1 Release this as Apache DataFusion Python 53.0.0 > > > > [ ] +0 > > > > [ ] -1 Do not release this as Apache DataFusion Python 53.0.0 > > because... > > > > > > > > Here is my vote: > > > > > > > > +1 (binding) > > > > > > > > Verification note: The manually triggered "Verify Release Candidate" > > > > workflow was run for version 53.0.0 and rc_number 1 across all > > configured > > > > OS/architecture matrix entries, and all matrix jobs completed > > > successfully > > > > except on windows, but I believe that is due to a problem with that > > > > instance and not this release [5]. > > > > > > > > [1]: > > > > > > > > > > > > > > https://github.com/apache/datafusion-python/tree/af383af369ec442e3b88841df3ba791b3a383413 > > > > [2]: > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/datafusion/apache-datafusion-python-53.0.0-rc1 > > > > [3]: > > > > > > > > > > > > > > https://github.com/apache/datafusion-python/blob/af383af369ec442e3b88841df3ba791b3a383413/CHANGELOG.md > > > > [4]: https://test.pypi.org/project/datafusion/53.0.0/ > > > > [5]: > > > https://github.com/apache/datafusion-python/actions/runs/24194281277 > > > > > > > > > >
