+1 (binding). Verified signature, checksums, and that the tarball matches commit 992c806a. Built on macOS arm64 (JDK 17, Rust 1.98.1). RAT passed.
Thanks Andy! On Mon, Oct 5, 2026 at 6:15 AM Andy Grove <[email protected]> wrote: > Thanks for catching the NOTICE issue, Xuanwo. I created a PR to fix > this going forward. > > https://github.com/apache/datafusion-comet/pull/6657 > > On Mon, Oct 5, 2026 at 1:14 AM Xuanwo <[email protected]> wrote: > > > > +1 (non-binding) > > > > I verified the source archive's SHA-256 and SHA-512 checksums and > signature, matched its contents to 1.1.0-rc2, and checked LICENSE, NOTICE > and source packaging. > > > > I built the downloaded source on Linux. The native library tests passed > 1,773 tests, and the selected JVM suites passed 296 tests. > > > > In the staged Spark 4.1 binary and sources JARs, META-INF/NOTICE omits > the Apache Gluten attribution present in the source NOTICE.txt, although > the corresponding RewriteJoin code is included. Please preserve that > attribution in the packaged NOTICE files in the next release. > > > > Thanks, > > Xuanwo > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
