Thanks for catching the license issue, Manu. I approved your PR to fix this for the next release. Given that we've been shipping this way for ~2 years, I don't think we should hold up the 1.2.0 release to fix.
On Sun, Nov 1, 2026 at 7:18 AM Manu Zhang <[email protected]> wrote: > > > > > I know ASF projects running with incomplete LICENSE/NOTICE files for years > > > > My understanding is that known licensing omissions should be addressed > before release. The ASF release policy > <https://www.apache.org/legal/release-policy.html> requires LICENSE and > NOTICE to account for each package’s contents, including binary JARs. > > On Sun, Nov 1, 2026 at 8:41 PM Martin Grigorov via dev < > [email protected]> wrote: > > > +1 to release (non-binding) > > > > Tested on Linux x86_64 > > > > Martin > > > > On Sun, Nov 1, 2026 at 2:04 PM Martin Grigorov <[email protected]> > > wrote: > > > > > > > > > > > On Sun, Nov 1, 2026 at 8:37 AM Manu Zhang <[email protected]> > > wrote: > > > > > >> -1 (non-binding). I found an issue of jar file missing lz4/zstd licenses > > >> and opened https://github.com/apache/datafusion-comet/pull/7382 to fix. > > >> > > > > > > I know ASF projects running with incomplete LICENSE/NOTICE files for > > years > > > :-) > > > IMO this should not be a stopper for the release. > > > The PR could be merged for the next version. > > > > > > > > > > > >> > > >> Thanks Andy for driving the release. > > >> > > >> Bhargava Vadlamani <[email protected]>于2026年11月1日 周日13:25写道： > > >> > > >> > + 1(non-binding) . Verified on M5 Mac > > >> > Thank you Andy > > >> > > > >> > On Fri, 30 Oct 2026 at 17:47, Andy Grove <[email protected]> > > wrote: > > >> > > > >> > > Hi, > > >> > > > > >> > > I would like to propose a release of Apache DataFusion Comet version > > >> > 1.2.0. > > >> > > > > >> > > This release candidate is based on commit: > > >> > > ab46419fcc99bcd34aa4d89f7b545d5d51694a88 [1] > > >> > > The proposed release tarball and signatures are hosted at [2]. > > >> > > Pre-built jar files are available in a Maven staging repository [3]. > > >> > > The changelog is located at [4]. > > >> > > > > >> > > Please download, verify checksums and signatures, run the unit > > tests, > > >> and > > >> > > vote > > >> > > on the release. The vote will be open for at least 72 hours. > > >> > > > > >> > > Only votes from PMC members are binding, but all members of the > > >> community > > >> > > are > > >> > > encouraged to test the release and vote with "(non-binding)". > > >> > > > > >> > > The standard verification procedure is documented at > > >> > > > > >> > > > > >> > > > >> > > https://github.com/apache/datafusion-comet/blob/main/dev/release/verifying-release-candidates.md > > >> > > > > >> > > [ ] +1 Release this as Apache DataFusion Comet 1.2.0 > > >> > > [ ] +0 > > >> > > [ ] -1 Do not release this as Apache DataFusion Comet 1.2.0 > > because... > > >> > > > > >> > > Here is my vote: > > >> > > > > >> > > +1 > > >> > > > > >> > > [1]: > > >> > > > > >> > > > >> > > https://github.com/apache/datafusion-comet/tree/ab46419fcc99bcd34aa4d89f7b545d5d51694a88 > > >> > > [2]: > > >> > > > > >> > > > >> > > https://dist.apache.org/repos/dist/dev/datafusion/apache-datafusion-comet-1.2.0-rc1 > > >> > > [3]: > > >> > > > > >> https://repository.apache.org/#nexus-search;quick~org.apache.datafusion > > >> > > [4]: > > >> > > > > >> > > > >> > > https://github.com/apache/datafusion-comet/blob/ab46419fcc99bcd34aa4d89f7b545d5d51694a88/docs/source/changelog/1.2.0.md > > >> > > > > >> > > > > --------------------------------------------------------------------- > > >> > > To unsubscribe, e-mail: [email protected] > > >> > > For additional commands, e-mail: [email protected] > > >> > > > > >> > > > > >> > > > >> > > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
