+1 (non-binding)

Thanks for preparing the release. I checked:

[x] Checksums (SHA-256 and SHA-512) match
[x] Source tarball matches tag 56.0.0-rc1 / commit 
cce6374e6256b3b8892ec60674578cf32bc3a32c (no added, missing or changed files)
[x] No compiled binaries in the source tarball
[x] LICENSE and NOTICE look good
[x] cargo build --locked and cargo test --all --features=avro pass (14,173 
passed, 0 failed), sqllogictests 544/544 files pass
[noted] Signature verifiable from the release KEYS file
[noted] License headers

Notes:

1. The tarball is signed with key DD6CE5CFB57D0E4157146A8983C69ADE03271ACE, 
which is present in
   https://dist.apache.org/repos/dist/dev/datafusion/KEYS but not in
   https://dist.apache.org/repos/dist/release/datafusion/KEYS, so verifying 
with the release
   KEYS fails with NO_PUBKEY. dev/release/README.md requires the key in both 
files.

2. docs/source/contributor-guide/gsoc/gsoc_application_guidelines_2025.md and
   docs/source/contributor-guide/gsoc/gsoc_project_ideas_2025.md have no ASF 
license header
   (and are not in rat_exclude_files.txt).

Please add the signing key to the release KEYS before publishing; the GSoC doc 
headers can be fixed in a follow-up.

Xuanwo

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to