jmalkin commented on issue #39: Placement new URL: https://github.com/apache/incubator-datasketches-cpp/pull/39#issuecomment-505573381 Not obvious what gcc doesn't like about those tests, but removing those means we have no clue if any of this code is internally consistent or consistent with java's handling of inputs. So that's very bad. The placement new changes are good.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
