To expose the staging repository, I believe you "close" the repository. I always forget the terminology. Better double check that isn't the button to promote it to a release.
Kenn On Thu, Jul 25, 2019 at 12:21 PM Alexander Saydakov <[email protected]> wrote: > +1 > org.apache.datasketches package > Apache license > successful 'mvn test' > > On Thu, Jul 25, 2019 at 11:48 AM leerho <[email protected]> wrote: > > > +1 > > > > NOTE: The Jar and pom attributes have been deployed to Nexus Staging > > Repository "orgapachedatasketches-1000", which can be examined from the > > Nexus UI. However, the link > > > > > https://repository.apache.org/content/repositories/orgapachedatasketches-1000/ > > returns the message: > > "Repository "orgapachedatasketches-1000 (staging: open)" > > [id=orgapachedatasketches-1000] exists but is not exposed." I do not know > > how to "expose" this. > > > > In addition to the checks make by prior voters, I ran the following > checks: > > > > - Checkstyle: passes with no warnings. This uses the configuration > > MemoryCheckstyle.xml located in the /tools/ directory. > > - SpotBugs: passes with no bugs found: This uses the configuration > > FindBugsExcludeFilter.xml located in the /tools/directory. > > - *mvn clean javadoc:javadoc* produces no javadoc errors. The javadocs > > can be found under */target/site/ * > > - *mvn versions:display-plugin-updates.* This has 2 warnings, but the > > versions are inherited from the super-pom. > > - [WARNING] The following plugins do not have their version > > specified: > > - [WARNING] maven-assembly-plugin ....................... (from > > super-pom) 2.6 > > - [WARNING] maven-compiler-plugin ..................... (from > > super-pom) 3.5. > > > > In the next release we can add the version numbers to the local pom to > > eliminate this warning. > > > > Lee. > > > > On Wed, Jul 24, 2019 at 3:02 PM Kenneth Knowles <[email protected]> wrote: > > > > > +1 > > > > > > Double-checked DISCLAIMER, LICENSE, NOTICE. And `mvn install` succeeded > > > without any extra work so that's nice :-) > > > > > > I would amend the process that the vote should remain open for 72 > hours, > > > regardless of +1s, per https://www.apache.org/foundation/voting.html. > > You > > > are looking not just for +1s but also any possible -1s. > > > > > > I have a number of other minor points which do not fail the release. > I'll > > > separate that from the [VOTE] thread. > > > > > > Kenn > > > > > > On Wed, Jul 24, 2019 at 10:59 AM leerho <[email protected]> wrote: > > > > > >> Thank you!!! > > >> > > >> On Wed, Jul 24, 2019 at 10:54 AM Furkan KAMACI < > [email protected]> > > >> wrote: > > >> > > >>> Hi Lee, > > >>> > > >>> Thanks for the detailed explanation! We can consider it later to have > > one > > >>> big repo or not. I can help with release and code management apart > from > > >>> mentoring. However, as I said, wen can talk about it later at another > > >>> email > > >>> thread. > > >>> > > >>> Kind Regards, > > >>> Furkan KAMACI > > >>> > > >>> On Wed, Jul 24, 2019 at 8:48 PM leerho <[email protected]> wrote: > > >>> > > >>> > Furkan, > > >>> > > > >>> > Thank you for your vote! > > >>> > > > >>> > I'm not sure I understand your question. The RC is in: > > >>> > > > >>> > > > >>> > > > https://dist.apache.org/repos/dist/dev/incubator/datasketches/memory/1.0.0-incubating-RC2/ > > >>> > > > >>> > I am guessing that your question is why the extra layer of > > >>> subdirectories? > > >>> > > > >>> > The 8 subdirectories under > > >>> > https://dist.apache.org/repos/dist/dev/incubator/datasketches/ > > >>> > are for the 8 GitHub repositories currently holding the code and > > >>> parallel > > >>> > the repositories we had under > > >>> > https://github.com/datasketches. > > >>> > > > >>> > We had a discussion with our mentor [email protected] early on about > > >>> why we > > >>> > needed multiple repos and he felt it was OK. Historically, we had > > >>> split up > > >>> > our code into separate repos because they have vastly different > > >>> dependency > > >>> > requirements, different compilation requirements and / or different > > >>> > versioning. > > >>> > > > >>> > DataSketches is not like a single application that has a single > > >>> version. > > >>> > It is a library of sketch functions, written in multiple languages > > >>> (Java, > > >>> > C++, Python) and adapted to different systems such as Hadoop Hive, > > >>> Hadoop > > >>> > Pig, Druid and Postgres. Although we have designed these sketches > > to > > >>> be > > >>> > binary compatible in stored form across different languages and > > >>> > environments, there will be subtle differences in capability due to > > >>> > language differences, environment differences, demand from the > > >>> community, > > >>> > and the fact that our resources are limited to write the code that > > >>> provides > > >>> > functional parity across these languages and systems. > > >>> > > > >>> > In theory, I would be possible to shove everything into one big > repo. > > >>> But > > >>> > that adds a lot of complexity into the release process (as well as > > >>> > introducing other issues), and we don't have an experienced > "release > > >>> > engineer" in our community. By being part of the larger Apache > > >>> community, > > >>> > we hope that we can find someone that is interested in what we are > > >>> doing > > >>> > and advise and consult with us on our release process and strategy. > > >>> > > > >>> > Lee. > > >>> > > > >>> > > > >>> > > > >>> > > > >>> > On Wed, Jul 24, 2019 at 8:57 AM Furkan KAMACI < > > [email protected]> > > >>> > wrote: > > >>> > > > >>> > > Hi, > > >>> > > > > >>> > > +1 from me. > > >>> > > > > >>> > > I checked: > > >>> > > - Incubating in name > > >>> > > - Disclaimer exists > > >>> > > - LICENSE is fine > > >>> > > - NOTICE is fine > > >>> > > - No unexpected binary files > > >>> > > - Code compiles and tests successfully run > > >>> > > > > >>> > > By the way, does RC exists in > > >>> > > https://dist.apache.org/repos/dist/dev/incubator/datasketches/ > > >>> > > > > >>> > > i.e. https://dist.apache.org/repos/dist/dev/incubator/rya/ or > > >>> > > https://dist.apache.org/repos/dist/dev/incubator/tuweni/ > > >>> > > > > >>> > > Kind Regards, > > >>> > > Furkan KAMACI > > >>> > > > > >>> > > On Wed, Jul 24, 2019 at 2:07 AM Jon Malkin <[email protected] > > > > >>> wrote: > > >>> > > > > >>> > > > The effective weight of my vote is zero, but +1 for > > compile/install > > >>> > > > working with all tests passed. > > >>> > > > > > >>> > > > jon > > >>> > > > > > >>> > > > On Tue, Jul 23, 2019 at 3:41 PM leerho <[email protected]> > wrote: > > >>> > > > > > >>> > > >> Typo: The first line should read: 1. This is a call for vote > to > > >>> > release > > >>> > > >> Apache DataSketches-memory version: 1.0.0-incubating-RC2 > > >>> > > >> > > >>> > > >> On Tue, Jul 23, 2019 at 3:36 PM leerho <[email protected]> > > wrote: > > >>> > > >> > > >>> > > >> > Hello Apache DataSketches Community, > > >>> > > >> > > > >>> > > >> > 1. This is a call for vote to release Apache > > DataSketches-memory > > >>> > > >> version: > > >>> > > >> > 1.0.0-incubating-RC1 > > >>> > > >> > > > >>> > > >> > NOTE 1: This is one component of the DataSketches library > > which > > >>> > needs > > >>> > > to > > >>> > > >> > be released first as other > > >>> > > >> > repositories have a dependency on this one. Once this is > > >>> released, > > >>> > the > > >>> > > >> > other components of the library > > >>> > > >> > will be able to be released. > > >>> > > >> > > > >>> > > >> > NOTE 2: All of the code has been properly refactored with > > >>> > > >> > "org.apache.datasketches...". > > >>> > > >> > All source files have the proper Apache license and have > been > > >>> > checked > > >>> > > >> with > > >>> > > >> > the Maven Rat Plugin. > > >>> > > >> > The code passes all tests with a coverage of > 98%. > > >>> > > >> > > > >>> > > >> > 2. The release candidate: > > >>> > > >> > > > >>> > > >> > > > >>> > > >> > > >>> > > > > >>> > > > >>> > > > https://dist.apache.org/repos/dist/dev/incubator/datasketches/memory/1.0.0-incubating-RC2/apache-datasketches-memory-1.0.0-incubating-src.zip > > >>> > > >> > > > >>> > > >> > 3. Source repository: > > >>> > > >> > https://github.com/apache/incubator-datasketches-memory > > >>> > > >> > > > >>> > > >> > Git Tag for this release: > > >>> > > >> > > > >>> > > >> > > > >>> > > >> > > >>> > > > > >>> > > > >>> > > > https://github.com/apache/incubator-datasketches-memory/tree/1.0.0-incubating-RC2 > > >>> > > >> > > > >>> > > >> > Git HashId for this release starts with: ec8f16e > > >>> > > >> > > > >>> > > >> > The artifacts have been signed with --keyid-format SHORT : > > >>> 8CD4A902 > > >>> > > >> > > > >>> > > >> > 4. Repository: dist.apache.org repository: > > >>> > > >> > > > >>> > > >> > The public signing key can be found in the KEYS file: > > >>> > > >> > > > >>> https://dist.apache.org/repos/dist/dev/incubator/datasketches/KEYS > > >>> > > >> > > > >>> > > >> > Upon acceptance, the above artifacts will be deployed into > the > > >>> > > official > > >>> > > >> > Apache release repository: > > >>> > > >> > > > >>> > > >> > > >>> > > > > >>> > > > >>> > > > https://dist.apache.org/repos/dist/release/incubator/datasketches/memory/ > > >>> > > >> > > > >>> > > >> > 5. Repository: Maven Central (repository.apache.org): > > >>> > > >> > > > >>> > > >> > Upon acceptance the jar artifacts will be generated from the > > >>> source > > >>> > > >> > repository and deployed > > >>> > > >> > to the Apache Maven Central staging repository: > > >>> > > >> > > > >>> > > >> > > > >>> > > >> > > > >>> > > >> > > >>> > > > > >>> > > > >>> > > > https://repository.apache.org/content/groups/staging/org/apache/datasketches/memory/ > > >>> > > >> > > > >>> > > >> > And then released into > > >>> > > >> > > > >>> > > >> > > > >>> > > >> > > >>> > > > > >>> > > > >>> > > > https://repository.apache.org/content/repositories/releases/datasketches/memory/ > > >>> > > >> > > > >>> > > >> > 6. Build Guide: > > >>> > > >> > > > >>> > > >> > The DataSketches-memory component is pure Java and is > > >>> structured as > > >>> > a > > >>> > > >> > Maven project. You must compile using JDK 8. There is one > > >>> run-time > > >>> > > >> > dependency and, of course, a number of test and Maven plugin > > >>> > > >> dependencies, > > >>> > > >> > all of which can be resolved by Maven. > > >>> > > >> > > > >>> > > >> > This component is a set of low-level library functions that > is > > >>> used > > >>> > by > > >>> > > >> the > > >>> > > >> > other DataSketches components. It has no user interface so > > the > > >>> only > > >>> > > >> thing > > >>> > > >> > you can do is compile and run the unit tests. > > >>> > > >> > There are two types of tests: normal unit tests and tests > run > > >>> by the > > >>> > > >> > strict profile. To run normal unit tests: > > >>> > > >> > > > >>> > > >> > $ mvn clean test > > >>> > > >> > > > >>> > > >> > To run the strict profile tests: > > >>> > > >> > > > >>> > > >> > $ mvn clean test -P strict > > >>> > > >> > > > >>> > > >> > Note also that when running the test suite, you might get > the > > >>> > > following > > >>> > > >> > message: > > >>> > > >> > > > >>> > > >> > SLF4J: Failed to load class > > >>> "org.slf4j.impl.StaticLoggerBinder". > > >>> > > >> > SLF4J: Defaulting to no-operation (NOP) logger > > implementation > > >>> > > >> > SLF4J: See > > http://www.slf4j.org/codes.html#StaticLoggerBinder > > >>> for > > >>> > > >> > further details. > > >>> > > >> > > > >>> > > >> > This is normal. It just indicates that in your environment, > > >>> you do > > >>> > > not > > >>> > > >> > have a logger in your class-path so the default logger of a > > >>> no-op is > > >>> > > >> used > > >>> > > >> > instead. > > >>> > > >> > > > >>> > > >> > To install jars in your local .m2 repository: > > >>> > > >> > > > >>> > > >> > $ mvn clean install > > >>> > > >> > > > >>> > > >> > 7. If you are interested in the actual functions of the > > Memory, > > >>> you > > >>> > > will > > >>> > > >> > need to write some code that calls the Memory functions. > > >>> > > >> > > > >>> > > >> > The documentation for the DataSketches Memory component is > > part > > >>> of > > >>> > the > > >>> > > >> > website. > > >>> > > >> > > > >>> > > >> > Overview documentation: > > >>> > > >> > - > > https://datasketches.github.io/docs/Memory/MemoryPackage.html > > >>> > > >> > - > > >>> https://datasketches.github.io/docs/Memory/MemoryPerformance.html > > >>> > > >> > > > >>> > > >> > Javadocs: > > >>> > > >> > > > >>> > > > https://datasketches.github.io/api/memory/snapshot/apidocs/index.html > > >>> > > >> > > > >>> > > >> > This particular component has been split out from the rest > of > > >>> the > > >>> > > >> > DataSketches code because there have been a number of > requests > > >>> from > > >>> > > >> folks > > >>> > > >> > that are interested in these high-performance functions > > >>> > independently > > >>> > > of > > >>> > > >> > the remainder of the DataSketches library. > > >>> > > >> > > > >>> > > >> > > > >>> > > >> > 8. The vote will be performed in two stages: > > >>> > > >> > - This letter will be published on dev@ open for at > least > > 72 > > >>> > hours > > >>> > > >> or > > >>> > > >> > until necessary number of votes are reached. > > >>> > > >> > - This letter will be published on incubator@general for > > at > > >>> > least > > >>> > > 72 > > >>> > > >> > hours or until necessary number of votes are reached. > > >>> > > >> > > > >>> > > >> > Anybody can vote, but only IPMC member's votes count. > > >>> > > >> > > > >>> > > >> > Please vote accordingly: > > >>> > > >> > > > >>> > > >> > [ ] +1 approve > > >>> > > >> > [ ] +0 no opinion > > >>> > > >> > [ ] -1 disapprove with the reason > > >>> > > >> > > > >>> > > >> > Thanks, > > >>> > > >> > The Apache DataSketches Team > > >>> > > >> > > > >>> > > >> > > >>> > > > > > >>> > > > > >>> > > > >>> > > >> > > >
