AlexanderSaydakov opened a new pull request #50: Hll cleanup URL: https://github.com/apache/incubator-datasketches-cpp/pull/50 - added hll_sketch and hll_union aliases with default allocator for convenience - added HllSketch move constructor - removed copy(), copyPtr() methods - converted copyAs() to copy constructor - simplified HllUnion by having gadget as an object (not a pointer) that can take care of itself - removed unused files and obsolete commented-out code - converted two remaining "delete" calls to "deallocate" - added "const" where appropriate (perhaps not everywhere) - adjusted size type in a few places to avoid compiler warning (signed and unsigned comparison) - added virtual destructor in iterator
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
