leventov commented on issue #109: Cache arrayBaseOffset. URL: https://github.com/apache/incubator-datasketches-memory/pull/109#issuecomment-516917736 > Would you suggest a particular method to determine which approach is best? The method is to develop a set of benchmarks very carefully, but this is inadequately effort-consuming task for the benefit. If you believe that if-else chain is clearer you can leave it. I still think `IdentityHashMap` would be better, but consider this an optional comment now.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
