gianm commented on issue #109: Cache arrayBaseOffset. URL: https://github.com/apache/incubator-datasketches-memory/pull/109#issuecomment-517043935 I think it is believable that the overhead of computing hash codes, etc, even if consistent, could outweigh the risks inherent in the if/else chain. Furthermore I would guess that in the majority of cases, callers will be using the same kind of backing array types over and over again, meaning branch prediction should be easy. For these reasons I'd prefer to keep the patch the way it is. But I can change it if required. I agree with you that developing benchmarks to determine what's really best is probably not worth the time. (It is at least something I do not have time budgeted for)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
