jmalkin commented on issue #53: Fix cmake install URL: https://github.com/apache/incubator-datasketches-cpp/pull/53#issuecomment-518757632 Ah, forgot to remove those references to the files. When initially writing HLL it mirrored the Java version exactly. But we ultimately decided that, since C++ doesn't limit you to a single class name per file like Java, that it'd be a nicer interface to define both the sketch and union in a single header, and have that one file contain the entire public API. HllSketch.hpp and HllUnion.hpp were entirely commented out, so as part of code cleanup we (read: @AlexanderSaydakov) remembered to remove them. Because I kept forgetting to do so. Just FYI, I have a branch converting HLL from camelCase to lower_with_underscores (still in progress). Eventually all the code, but we're trying to get a consistent interface style across all our classes before the first formal release.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
