Furkan, Thank you for the vote! And for the suggestion to update README.
Where did you find the folder name with at space character? Lee On Mon, Sep 9, 2019 at 1:55 PM Furkan KAMACI <[email protected]> wrote: > Hi, > > +1 from me. > > I checked: > - Incubating in name > - DISCLAIMER exists > - LICENSE and NOTICE are fine > - No unexpected binary files > - Checked PGP signatures > - Checked Checksums > - Code compiles and tests successfully run > > Minor things: > > 1) You can update README file at GitHub both for how to compile it and > discussion & support. i.e.: https://github.com/apache/lucene-solr > 2) Seems that project fails to run tests when folder name has space > character. > > Kind Regards, > Furkan KAMACI > > On Fri, Sep 6, 2019 at 10:32 PM Jon Malkin <[email protected]> wrote: > > > +1 > > > > Verified signature and checksum > > Licenses/notices present, although I still need to learn details of what > > they're supposed to include so I just checked for non-empty files > > Successfully compiled and ran unit tests. > > > > jon > > > > On Thu, Sep 5, 2019 at 6:53 PM leerho <[email protected]> wrote: > > > > > ### NEW COMPONENT! ### > > > > > > Hello Apache DataSketches PPMC and Community, > > > > > > 1. This is a call for vote to release Apache DataSketches-java version: > > > 1.0.0-incubating-RC2 > > > > > > NOTE 1: This is the core Java component of the DataSketches library > > > that includes all the sketch algorithms in production-ready packages. > > These > > > sketches can be called directly from this component or used in > > conjunction > > > with the adaptor components such as Hadoop Pig, Hadoop Hive, or the > > > aggregator adaptors built into Apache Druid. > > > > > > NOTE 2: This release contains some critical performance > improvements > > > and bug fixes for Apache Druid. > > > > > > NOTE 3: Changes from RC1: The previous RC1 had a bug in the release > > > script which caused the SHA512sum to fail. Some very minor updates to > the > > > LICENSE, NOTICE, and pom.xml files. Otherwise no code changes. > > > > > > 2. The release candidate: > > > - > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/datasketches/java/1.0.0-incubating-RC2/ > > > > > > 3. Source repository: > > > - https://github.com/apache/incubator-datasketches-java > > > > > > Git Tag for this release: > > > - > > > > > > > > > https://github.com/apache/incubator-datasketches-java/tree/1.0.0-incubating-RC2 > > > on branch 1.0.X-incubating > > > > > > Git HashId for this release starts with: f8abbbe > > > > > > The artifacts have been signed with --keyid-format SHORT : 8CD4A902 > > > > > > 4. Repository: dist.apache.org repository: > > > > > > The public signing key can be found in the KEYS file: > > > - > https://dist.apache.org/repos/dist/dev/incubator/datasketches/KEYS > > > > > > 5. Repository: Maven Central (repository.apache.org): > > > > > > The Jar artifacts can be found at > > > - > > > > > > > > > https://repository.apache.org/content/groups/staging/org/apache/datasketches/datasketches-java/1.0.0-incubating/ > > > > > > 6. Build & Test Guide: (assuming you have Maven) > > > > > > The DataSketches-java component is pure Java and is structured as a > > > Maven project. You must compile using JDK 8. There is one run-time > > > dependency of the DataSketches-memory component (recently released), > and, > > > of course, a number of test and Maven plugin dependencies, all of which > > can > > > be resolved by Maven. > > > > > > There are two types of tests: normal unit tests and tests run by > the > > > strict profile. To run normal unit tests: > > > > > > $ mvn clean test > > > > > > To run the strict profile tests: > > > > > > $ mvn clean test -P strict > > > > > > To install jars in your local .m2 repository: > > > > > > $ mvn clean install -DskipTests=true > > > > > > 7. Documentation: The documentation for the DataSketches Java component > > is > > > part of the website. > > > > > > The Overview section on the website has extensive documentation on > > all > > > the sketches: > > > - https://datasketches.github.io > > > > > > Javadocs: > > > - > > https://datasketches.github.io/api/core/snapshot/apidocs/index.html > > > > > > 8. The vote will be performed in two stages: > > > - This letter will be published on dev@ and remain open for at > least > > 72 > > > hours and at least 3 (+1) PPMC votes or a majority of (+1) are > > > acquired. All PPMC members including Mentors can vote. However, a > > negative > > > vote from a Mentor will cancel this voting process. > > > > > > - After it passes the first stage, the summary of that vote and the > > key > > > information from this letter will be published on general@incubator > and > > > remain open for at least 72 hours and at least 3 (+1) IPMC votes or a > > > majority of (+1) are acquired. > > > > > > Please vote accordingly: > > > > > > [ ] +1 approve > > > [ ] +0 no opinion > > > [ ] -1 disapprove with the reason > > > > > > Thanks, > > > Lee Rhodes > > > [email protected] > > > > > >
