Thanks Lee for your report! I see that a minor adjustment to the Makefile is necessary to make it work on MacOSX with Apple clang compiler. It works for me because I use gcc, but clang does not like this -std=c++11 while compiling in C mode.
Please consider this call for vote cancelled. I will prepare RC2 shortly with modified Makefile and the suggested clarifications in README. Please note that there is another problem with the current MacOSX Mojave 10.4.6, which is not our fault at all: there appears to be a wrong link in /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs: MacOSX.sdk MacOSX10.15.sdk -> MacOSX.sdk This link has to be: MacOSX10.14.sdk -> MacOSX.sdk in order for clang compiler to work properly On Wed, Oct 16, 2019 at 3:33 PM leerho <[email protected]> wrote: > -1 > > *README.md */ *Building and installing from source * > Did not work for me. Here are my notes: > > 1. Some more explanation of the two Building options PGXN vs "source" > would be helpful. > > 2. Explain that both options will need to have postgresql installed, and > point to the Postgresql install site. > > 3. The first link under README.md / How to build and install: "PGXN site" > is a 404. > > 4. Some additional hints to the user would be helpful: > - The user needs to install or update to the latest version of > datasketches-cpp. > - If there is a minimum version of datasketches-cpp required it is not > stated. > - Running "make" gives me a warning and Error: (I put each of the > parameters on separate lines to make it more readable:) > > > make > clang > -Wall > -Wmissing-prototypes > -Wpointer-arith > -Wdeclaration-after-statement > -Wendif-labels > -Wmissing-format-attribute > -Wformat-security > -fno-strict-aliasing > -fwrapv > -Wno-unused-command-line-argument > -O2 > -std=c++11 > -fPIC > -I/usr/local/include > -Idatasketches-cpp/kll/include > -Idatasketches-cpp/common/include > -Idatasketches-cpp/cpc/include > -Idatasketches-cpp/theta/include > -Idatasketches-cpp/fi/include > -Idatasketches-cpp/hll/include > -I. > -I./ > -I/usr/local/Cellar/postgresql/11.5_1/include/server > -I/usr/local/Cellar/postgresql/11.5_1/include/internal > -I/usr/local/Cellar/icu4c/64.2/include > -isysroot > > /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk > -I/usr/local/opt/[email protected]/include > -I/usr/local/opt/readline/include > > > -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include/libxml2 > > -c > -o src/global_hooks.o src/global_hooks.c > clang: warning: no such sysroot directory: > > '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk' > [-Wmissing-sysroot] > error: invalid argument '-std=c++11' not allowed with 'C' > make: *** [src/global_hooks.o] Error 1 > > > > Lee. > > On Fri, Oct 11, 2019 at 9:54 AM Dave Fisher <[email protected]> wrote: > > > +1 (binding) > > > > Check signature and checksums > > Incubating in name > > No Binaries > > License checks > > Notice checks > > Headers on code files. (Missing for package.sh, README.md, Makefile > please > > fix for the next release) > > > > Could not build as I don’t have Postgresql installed. > > > > I’m looking forward to the website documentation. > > > > Regards, > > Dave > > > > > On Oct 10, 2019, at 4:11 PM, Alexander Saydakov < > > [email protected]> wrote: > > > > > > Dear Apache DataSketches PPMC and Community, > > > > > > This is a call for vote to release Apache DataSketches-postgresql > > > version 1.3.0-incubating-rc1 > > > > > > This is an extension for PostgreSQL database based on the > > > datasketches-cpp core library (version 1.0.0-incubating). > > > > > > This is the first release of this component as an Apache Incubator > > project. > > > > > > Source repository: > > > https://github.com/apache/incubator-datasketches-postgresql > > > > > > Git tag for this release candidate: > > > > > > https://github.com/apache/incubator-datasketches-postgresql/tree/1.3.0-incubating-rc1 > > > on branch 1.3.x-incubating > > > > > > The release candidate repository: > > > > > > https://dist.apache.org/repos/dist/dev/incubator/datasketches/postgresql/1.3.0-incubating-rc1/ > > > > > > How to build and install: > > > > > > https://github.com/apache/incubator-datasketches-postgresql/blob/1.3.0-incubating-rc1/README.md > > > > > > The vote will be performed in two stages: > > > - This call for vote will be published on dev@ and remain open for > at > > > least 72 hours and until at least 3 (+1) PPMC votes or a majority of > (+1) > > > are acquired. All PPMC members including Mentors can vote. However, a > > > negative vote from a Mentor will cancel this voting process. > > > - After it passes the first stage, another call for vote with the > > > summary of this vote and the key information from this letter will be > > > published on general@incubator and remain open for at least 72 hours > > and at > > > least 3 (+1) IPMC votes or a majority of (+1) are acquired. > > > > > > Please vote accordingly: > > > > > > [ ] +1 approve > > > [ ] +0 no opinion > > > [ ] -1 disapprove with the reason > > > > > > Thank you. > > > Alexander Saydakov > > > [email protected] > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > >
