I agree that the release of 2.0.0 does not have to be dependant on cross-language validation testing as that is a release process issue that spans multiple components. So the issue #150 can be removed.
On Thu, May 28, 2020 at 7:42 AM leerho <[email protected]> wrote: > [-1] due to issue #149 > <https://github.com/apache/incubator-datasketches-cpp/issues/149>, issue > #150 <https://github.com/apache/incubator-datasketches-cpp/issues/150> > Sorry team, another serious bug was discovered this morning. Also, I > don't think we should release 2.0.0 until we have resolved our lack of > cross-validation testing, > > On Thu, May 28, 2020 at 12:16 AM Jon Malkin <[email protected]> wrote: > >> ### Major version: Fully allocator-aware, header only. Varopt sampling >> added. Exception-safe. API changes for consistency. ### >> >> ### RC3 fixes a newly identified bug in the murmur3 hash function: >> https://issues.apache.org/jira/browse/DATASKETCHES-5 ### >> >> >> Hello Apache DataSketches PPMC and Community, >> >> 1. This is a call for vote to release Apache DataSketches-cpp version: >> 2.0.0-incubating-rc3 >> >> NOTE 1: The C++ code provides header-only library. Compilation is needed >> only to build unit tests. A Python extension is also included in this >> repository as a set of thin wrappers. That does produce a compiled artifact, >> but is not built by default. >> >> NOTE 2: Compiling the C++ unit tests requires CMake 3.12 or newer. >> >> 2. Source repository: >> - https://github.com/apache/incubator-datasketches-cpp >> >> Git Tag for this release: >> - >> https://github.com/apache/incubator-datasketches-cpp/tree/2.0.0-incubating-rc3 >> on branch 2.0.x-incubating >> >> Git HashId for this release starts with: dbc8b4a >> >> 3. The Release Candidate / Zip Repository: >> - >> https://dist.apache.org/repos/dist/dev/incubator/datasketches/cpp/2.0.0-incubating-rc3/ >> >> The public signing key can be found in the KEYS file: >> - https://dist.apache.org/repos/dist/dev/incubator/datasketches/KEYS >> >> The artifacts have been signed with --keyid-format SHORT : 38F334CC >> >> 4. C++ Test Guide: >> - >> https://github.com/apache/incubator-datasketches-cpp/blob/2.0.0-incubating-rc3/README.md >> 5. Python Build & Test Guide: >> - >> https://github.com/apache/incubator-datasketches-cpp/blob/2.0.0-incubating-rc3/python/README.md >> >> 6. The vote will be performed in two stages: >> - This letter will be published on dev@ and remain open for at least 72 >> hours and at least 3 (+1) PPMC votes or a majority of (+1) are acquired. All >> PPMC members including Mentors can vote. However, a negative vote from a >> Mentor will cancel this voting process. >> >> - After it passes the first stage, the summary of that vote and the key >> information from this letter will be published on general@incubator and >> remain open for at least 72 hours and at least 3 (+1) IPMC votes or a >> majority of (+1) are acquired. >> >> Please vote accordingly: >> >> [ ] +1 approve >> [ ] +0 no opinion >> [ ] -1 disapprove with the reason >> Thanks, >> Jon [email protected] <http://jmalkinapache.org> >> >>
