+1 (binding) What I checked: * PGP signiture * checksum * C++ test tested * Python wrapper tested
- Evans Alexander Saydakov <[email protected]> 於 2020年6月5日 週五 上午4:48寫道： > +1 > Checked: > - gpg signature > - shasum > - cmake, make, make test > > > On Wed, Jun 3, 2020 at 8:10 PM leerho <[email protected]> wrote: > >> +1 >> I checked: >> - DISCLAIMER-WIP, LICENSE and NOTICE are fine >> - checked GPG and shasum signatures OK >> - cmake, make, make test OK >> - git.properties are correct (match the vote letter and GitHub): >> - git.branch OK >> - git.commit.id OK >> - git.commit.tag OK >> >> >> On Wed, Jun 3, 2020 at 2:13 PM Furkan KAMACI <[email protected]> >> wrote: >> >>> Hi, >>> >>> +1 from me (binding, carrying over). >>> >>> I checked: >>> >>> - Incubating in name >>> - DISCLAIMER-WIP exists >>> - LICENSE and NOTICE are fine >>> - Checked PGP signatures >>> - Checked Checksums >>> - cmake, make, make test for cpp >>> - python wrapper build (tried with python3) >>> >>> Kind Regards, >>> Furkan KAMACI >>> >>> On Wed, Jun 3, 2020 at 10:05 PM Jon Malkin <[email protected]> wrote: >>> >>>> >>>> - >>>> >>>> ### Major version: Fully allocator-aware, header only. Varopt sampling >>>> added. Exception-safe. API changes for consistency. ### >>>> >>>> ### RC4 fixes two issues reported right after RC3 was submitted: #149 >>>> <https://github.com/apache/incubator-datasketches-cpp/issues/149> and #152 >>>> <https://github.com/apache/incubator-datasketches-cpp/issues/152> ### >>>> >>>> >>>> Hello Apache DataSketches PPMC and Community, >>>> >>>> - Apologies for yet another RC. On the positive side, the library >>>> is being used and scrutinized enough to find some bugs that really >>>> needed >>>> to be fixed. >>>> >>>> >>>> - >>>> >>>> 1. This is a call for vote to release Apache DataSketches-cpp version: >>>> 2.0.0-incubating-rc3 >>>> >>>> NOTE 1: The C++ code provides header-only library. Compilation is >>>> needed only to build unit tests. A Python extension is also included in >>>> this repository as a set of thin wrappers. That does produce a compiled >>>> artifact, but is not built by default. >>>> >>>> NOTE 2: Compiling the C++ unit tests requires CMake 3.12 or newer. >>>> >>>> 2. Source repository: >>>> - https://github.com/apache/incubator-datasketches-cpp >>>> >>>> Git Tag for this release: >>>> - >>>> https://github.com/apache/incubator-datasketches-cpp/tree/2.0.0-incubating-rc4 >>>> on branch 2.0.x-incubating >>>> >>>> Git HashId for this release starts with: 90b6689 >>>> >>>> 3. The Release Candidate / Zip Repository: >>>> - >>>> https://dist.apache.org/repos/dist/dev/incubator/datasketches/cpp/2.0.0-incubating-rc4/ >>>> >>>> The public signing key can be found in the KEYS file: >>>> - https://dist.apache.org/repos/dist/dev/incubator/datasketches/KEYS >>>> >>>> The artifacts have been signed with --keyid-format SHORT : 38F334CC >>>> >>>> 4. C++ Test Guide: >>>> - >>>> https://github.com/apache/incubator-datasketches-cpp/blob/2.0.0-incubating-rc4/README.md >>>> 5. Python Build & Test Guide: >>>> - >>>> https://github.com/apache/incubator-datasketches-cpp/blob/2.0.0-incubating-rc4/python/README.md >>>> >>>> 6. The vote will be performed in two stages: >>>> - This letter will be published on dev@ and remain open for at least >>>> 72 hours and at least 3 (+1) PPMC votes or a majority of (+1) are >>>> acquired. All PPMC members including Mentors can vote. However, a negative >>>> vote from a Mentor will cancel this voting process. >>>> >>>> - After it passes the first stage, the summary of that vote and the >>>> key information from this letter will be published on general@incubator >>>> and remain open for at least 72 hours and at least 3 (+1) IPMC votes or a >>>> majority of (+1) are acquired. >>>> >>>> Please vote accordingly: >>>> >>>> [ ] +1 approve >>>> [ ] +0 no opinion >>>> [ ] -1 disapprove with the reason >>>> Thanks, >>>> Jon [email protected] <http://jmalkinapache.org> >>>> >>>> >>>>
