Hi,

+1 from me.

I checked:

- Incubating in name
- DISCLAIMER-WIP exists
- LICENSE and NOTICE are fine
- No unexpected binary files
- Checked PGP signatures
- Checked Checksums
- Code compiles and tests successfully run
- Apache rat checks are OK

*PS:* Source file [1] includes *git.properties* but git tag [2] does not.
You should remove it.

[1]
https://dist.apache.org/repos/dist/dev/incubator/datasketches/hive/1.1.0-incubating-RC1/apache-datasketches-hive-1.1.0-incubating-src.zip
[2]
https://github.com/apache/incubator-datasketches-hive/tree/1.1.0-incubating-RC1

Kind Regards,
Furkan KAMACI

On Sat, Jun 20, 2020 at 12:38 PM Evans Ye <[email protected]> wrote:

> +1 (binding)
>
> Checked:
> - gpg signature
> - sha512 sum
> - maven tests
> - disclaimer, notice, licence look good.
>
> - Evans
>
>
> Alexander Saydakov <[email protected]> 於 2020年6月16日 週二
> 上午3:52寫道:
>
>> +1
>>
>> Checked:
>> - gpg signature
>> - shasum
>> - mvn test
>> - mvn install
>> - copied resulting .jar to a Hive cluster (with datasketches-java 1.3.0)
>> and run a few example scripts (available on the web site)
>>
>> On Mon, Jun 15, 2020 at 10:02 AM Jon Malkin <[email protected]> wrote:
>>
>>> +1 from me
>>>
>>> I checked:
>>> - signature and checksum
>>> - mvn test and mvn package both work properly
>>> - no extra binaries or other unexpected files
>>> - incubating in name
>>> - LICENSE and NOTICE present, although I don't know enough to validate
>>> content
>>>
>>>   jon
>>>
>>> On Sat, Jun 13, 2020 at 5:12 PM leerho <[email protected]> wrote:
>>>
>>>> ### Critical Bug fix, minor licensing fixes, minor code cleanup. ###
>>>>
>>>> Hello Apache DataSketches PPMC and Community,
>>>>
>>>> 1. This is a call for vote to release Apache DataSketches-hive version:
>>>>  1.1.0-incubating-RC1
>>>>
>>>>     NOTE 1: This is the Java Hive adaptor component of the DataSketches
>>>> library that enables Apache Hive access to the key sketch algorithms in
>>>> production-ready packages: Sketches Included: CPC, FrequentItems, HLL, KLL,
>>>> Quantiles, Theta and Tuple.
>>>>
>>>> 2. Source repository:
>>>>     - https://github.com/apache/incubator-datasketches-hive
>>>>
>>>>     Git Tag for this release:
>>>>     -
>>>> https://github.com/apache/incubator-datasketches-hive/tree/1.1.0-incubating-RC1
>>>>
>>>>     Git HashId for this release starts with: 22bfbc2
>>>>
>>>> 3. The Release Candidate / Zip Repository:
>>>>     -
>>>> https://dist.apache.org/repos/dist/dev/incubator/datasketches/hive/1.1.0-incubating-RC1/
>>>>
>>>>     The public signing key can be found in the KEYS file:
>>>>     -
>>>> https://dist.apache.org/repos/dist/dev/incubator/datasketches/KEYS
>>>>
>>>>     The artifacts have been signed with --keyid-format SHORT : 8CD4A902
>>>>
>>>> 4. Repository: Maven Central [Nexus](http://repository.apache.org)
>>>> (Jar Artifacts):
>>>>     -
>>>> https://repository.apache.org/content/groups/staging/org/apache/datasketches/datasketches-hive/1.1.0-incubating/
>>>>
>>>> 5. Build & Test Guide:
>>>>     -
>>>> https://github.com/apache/incubator-datasketches-hive/blob/1.1.0-incubating-RC1/README.md
>>>>
>>>> 6. The vote will be performed in two stages:
>>>>    - This letter will be published on dev@ and remain open for at
>>>> least 72 hours and at least 3 (+1) PPMC votes or a majority of (+1) are
>>>> acquired. All PPMC members including Mentors can vote. However, a negative
>>>> vote from a Mentor will cancel this voting process.
>>>>
>>>>    - After it passes the first stage, the summary of that vote and the
>>>> key information from this letter will be published on general@incubator
>>>> and remain open for at least 72 hours and at least 3 (+1) IPMC votes or a
>>>> majority of (+1) are acquired.
>>>>
>>>> Please vote accordingly:
>>>>
>>>> [ ] +1 approve
>>>> [ ] +0 no opinion
>>>> [ ] -1 disapprove with the reason
>>>>
>>>> Thanks,
>>>> Lee Rhodes
>>>> [email protected]
>>>>
>>>

Reply via email to