We decided at some point that we should not support serializing a union. It seems that deserialize() methods have not been removed by mistake. We suggest serializing a sketch that can be obtained by calling get_result().
On Fri, Jul 17, 2020 at 2:20 AM Gabor Kaszab <[email protected]> wrote: > Hey, > > I have been working on the integration of Apache DataSketches HLL into > Apache Impala for a while now. > I used a snapshot from the c++ library using this commit at the top: > https://github.com/apache/incubator-datasketches-cpp/commit/a6265b307a03085abe26c20413fdbf7d7a5eaf29 > Recently I updated our snapshot and noticed that there was a change that > removed hll_union_alloc<A>::serialize_compact() functions that I actually > used in the Impala code: > > https://github.com/apache/incubator-datasketches-cpp/commit/92c3d309d78c91ae09b810c49bb2b6b05fa6d923 > > As I see deserialization() functions are still there so I assume there is > still a way to serialize hll_union even if there is no serialize() and > serialize_compact() functions. > > Could you help me out what is the current way of serializing such > hll_union objects? > Should I call get_result() to get the underlying hll_sketch and serialize > that? Woulg hll_union::deserialize() accept it as a parameter? > > Cheers, > Gabor >
