Sounds good. I think this brings us back to sketch parity with Java (adding req) so let's declare a freeze and start the RC process.
jon On Fri, Feb 26, 2021, 2:35 PM Alexander Saydakov <[email protected]> wrote: > I think we are ready for datasketches-cpp-3.0.0 release. It has to be a > major version release since we made incompatible changes in the new > implementation of theta sketch, which shares the common base with tuple > sketch. In particular, we removed serialization and deserialization methods > from the base theta sketch class and from the update sketch. Now only > compact theta sketches can be serialized. > > On Fri, Feb 12, 2021 at 1:51 PM Jon Malkin <[email protected]> wrote: > >> Hey everyone, >> >> I think we're about ready to do another c++ release. What we have so far: >> - Full custom allocator support everywhere >> - Add req sketch (also in python) >> - Move theta and tuple to share a common base >> - Added Jaccard similarity for theta/tuple sketches (also in python) >> - Finished removing a few supporting serialization methods from HLL union >> -- it couldn't be serialized before but I'd missed a few like querying the >> serialized size. >> >> Being hyper-technical about it, removing those methods would require a >> major version bump under semantic versioning. Since they were only useful >> in support of functionality that was already removed, I'd propose sticking >> with the 2.x line. >> >> Unless there's some specific objection, I'd propose a new release with >> what we have. >> >> jon >> >
