+1 (binding) - verified GPG signature - checked SHA sum - "make" and "make test"
On Wed, Mar 3, 2021 at 3:48 PM leerho <[email protected]> wrote: > +1 (binding) > > Checked: > - builds and tests run OK > - GPG signature OK > - Sha512sum OK > - License, Notice files look ok > - README has links to our website (for downloads) and community page > (for contacting us, contributing, etc.) > - The git.properties has the correct git.commit.id.full, git.commit.tag, > git.branch, and ArtifactId. > It looks really clean! > > Lee. > > On Wed, Mar 3, 2021 at 1:05 AM Jon Malkin <[email protected]> wrote: > >> +1 >> >> I checked: >> - shasum >> - gpg signature >> - cmake/make/make test >> - had to clone pybind11 into the relevant subdir manually, but then >> python tests ran viz tox >> - LICENSE and NOTICE present >> >> We do include the .github directory and .gitignore, but I think those are >> harmless. You can even use the CI workflow if you need a reminder of the >> relevant commands. >> >> I really need to add a CI job for the RAT tool at some point, but I did >> not check that. >> >> jon >> >> On Mon, Mar 1, 2021 at 4:44 PM Alexander Saydakov >> <[email protected]> wrote: >> >>> ### Introduction of new Relative Error Quantiles Sketch, >>> >>> ### Added Tuple sketch and rewritten Theta sketch to share the same base, >>> >>> ### Performance improvement of HLL sketch, >>> >>> ### Removed serialization of Update Theta sketch and Union, and HLL >>> Union, >>> >>> ### Added support for passing instances of allocators >>> >>> >>> Hello Apache DataSketches PMC and Community, >>> >>> >>> 1. This is a call for vote to release Apache DataSketches-cpp candidate >>> version: 3.0.0-rc1 >>> >>> >>> NOTE 1: This is the core C++ component of the DataSketches library >>> that includes all the sketch algorithms and Python bindings. These sketches >>> can be called directly from this component or used in conjunction with the >>> adaptor compone >>> >>> >>> 2. Source repository: >>> >>> - https://github.com/apache/datasketches-cpp >>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_datasketches-2Dcpp&d=DwMFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=0TpvE_u2hS1ubQhK3gLhy94YgZm2k_r8JHJnqgjOXx4&m=ZRqCGV3yQoU3skcaJZA3SIzpAy7c7laN96_gMNFmDRo&s=pBff2dj_ziWpBLZxCkBOr321xc5QJF3ToXzHsI6Rg8c&e=> >>> >>> >>> Git Tag for this release: >>> >>> - https://github.com/apache/datasketches-cpp/tree/3.0.0-rc1 >>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_datasketches-2Dcpp_tree_3.0.0-2Drc1&d=DwMFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=0TpvE_u2hS1ubQhK3gLhy94YgZm2k_r8JHJnqgjOXx4&m=ZRqCGV3yQoU3skcaJZA3SIzpAy7c7laN96_gMNFmDRo&s=5llKPaIY065HJq4nXOqG0ZYFi5LEGO5fIwC0cfUlVEg&e=> >>> on branch 3.0.x >>> >>> >>> Git HashId for this release starts with: 45885c0 >>> >>> >>> 3. The Release Candidate / Zip Repository: >>> >>> - https://dist.apache.org/repos/dist/dev/datasketches/cpp/3.0.0-rc1/ >>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__dist.apache.org_repos_dist_dev_datasketches_cpp_3.0.0-2Drc1_&d=DwMFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=0TpvE_u2hS1ubQhK3gLhy94YgZm2k_r8JHJnqgjOXx4&m=ZRqCGV3yQoU3skcaJZA3SIzpAy7c7laN96_gMNFmDRo&s=rZh1CZtgmVEMU3pBUzK1zjzDy1E7PheNGupJh8gJpIk&e=> >>> >>> >>> The public signing key can be found in the KEYS file: >>> >>> - https://dist.apache.org/repos/dist/dev/datasketches/KEYS >>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__dist.apache.org_repos_dist_dev_datasketches_KEYS&d=DwMFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=0TpvE_u2hS1ubQhK3gLhy94YgZm2k_r8JHJnqgjOXx4&m=ZRqCGV3yQoU3skcaJZA3SIzpAy7c7laN96_gMNFmDRo&s=LnLyIxUcJdklHrMYcFtq_yWLabrKjha05QlFZqgC2Y4&e=> >>> >>> >>> >>> The artifacts have been signed with key: >>> >>> 68486114A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY) < >>> [email protected]> >>> >>> >>> 4. Build & Test Guide: >>> >>> - >>> https://github.com/apache/datasketches-cpp/blob/45885c0c8c0807bb9480886d60ca7042000a4c43/README.md >>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_datasketches-2Dcpp_blob_45885c0c8c0807bb9480886d60ca7042000a4c43_README.md&d=DwMFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=0TpvE_u2hS1ubQhK3gLhy94YgZm2k_r8JHJnqgjOXx4&m=ZRqCGV3yQoU3skcaJZA3SIzpAy7c7laN96_gMNFmDRo&s=KogUAKAlv78_2Y2sPbTnRQ_s4lbVRthpGvu5NN7PK9c&e=> >>> >>> >>> 5. The vote will be performed as follows: >>> >>> - This letter will be published on dev@ and remain open for at least >>> 72 hours (excluding weekends and holidays), AND until at least 3 (+1) PMC >>> votes or a majority of (+1) PMC votes are acquired. Anyone in the community >>> can vote. >>> >>> >>> Please vote accordingly: >>> >>> >>> [ ] +1 approve >>> >>> [ ] +0 no opinion >>> >>> [ ] -1 disapprove with the reason >>> >>> >>> Thanks, >>> >>> Alexander Saydakov >>> >>> [email protected] >>> >>
