[
https://issues.apache.org/jira/browse/DATASKETCHES-10?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17305069#comment-17305069
]
Pavel Vesely commented on DATASKETCHES-10:
------------------------------------------
It's actually a simple find & replace to change float -> double in
KllFloatsSketch and ReqSketch. I've done that for both here:
[https://github.com/PavelVesely/t-digest/tree/master/core/src/main/java/com/tdunning/math/stats/datasketches]
(Disclaimer: I haven't done extensive testing that everything works correctly
with double – in particular, serialization/deserialization would require proper
tests.)
Pavel
> Double precision by default?
> ----------------------------
>
> Key: DATASKETCHES-10
> URL: https://issues.apache.org/jira/browse/DATASKETCHES-10
> Project: Apache Datasketches
> Issue Type: Improvement
> Reporter: Jan Prach
> Priority: Major
>
> Would it make sense to use double (instead of float) for all sketches by
> default?
> It would take (less than 2x) more memory, have same speed, have twice the
> storage. Or even the same storage if one is fine with the flaot precision.
> Most importantly it would be far more useful.
> I' trying to build generic profiler. In the first simple dataset there were a
> couple of date and timestamp columns. The obvious choice is to convert them
> to epoch seconds. Full day of time with weird messages only to realize that
> KllFloatsSketch, ReqSketch, etc. are all based on floats. That means 24 bit
> precision. But epoch seconds today are 31 bit numbers.
> Why not always double?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
