Hi,

+1 from me.

I checked:

- LICENSE and NOTICE are fine
- No unexpected binary files
- Checked PGP signatures
- Checked checksums
- Code compiles and tests successfully run

Kind Regards,
Furkan KAMACI

On Fri, May 14, 2021 at 9:55 PM Alexander Saydakov
<[email protected]> wrote:

> +1
> - checked signature and SHA sum
> - make, sudo make install
> - created extension in a test DB
> - run some test queries
>
>
> On Mon, May 10, 2021 at 10:14 AM leerho <[email protected]> wrote:
>
>> +1
>> brew install postgresql
>> make
>> sudo make install
>> brew services start postgresql
>> createdb test
>> create extension datasketches
>> select cpc_sketch_to_string(cpc_sketch_build(1));
>> // produced the example cpc_sketch_to_string output
>>
>> Lee.
>>
>> On Fri, May 7, 2021 at 2:17 PM Jon Malkin <[email protected]> wrote:
>>
>>> +1, although testing with the actual db was quite limited
>>>
>>> - brew install postgresql, which appears to have pulled in 13.2
>>> - checked shasum and gpg signature
>>> - make; sudo make install
>>> - created db, connected to it, ran a very few commands
>>>
>>>   jon
>>>
>>> On Thu, May 6, 2021 at 1:14 PM Alexander Saydakov
>>> <[email protected]> wrote:
>>>
>>>> Dear Apache DataSketches PMC and Community,
>>>>
>>>>
>>>> This is a call for vote to release
>>>> Apache DataSketches-postgresql version 1.4.0-rc2
>>>>
>>>>
>>>> This is an extension for PostgreSQL database based on the
>>>> Apache DataSketches-cpp core library.
>>>>
>>>>
>>>> Changes in this release (since 1.3.0):
>>>>
>>>>    - Based on the latest data sketches-cpp 3.0.0
>>>>    - Added aod_sketch (array-of-doubles tuple sketch)
>>>>    - Added req_float_sketch (REQ quantiles sketch with high accuracy
>>>>    at high or low ranks)
>>>>    - Added missing theta_sketch aggregate intersection
>>>>
>>>> META.json was updated since 1.4.0-rc1 (pgxn.org
>>>> <https://urldefense.proofpoint.com/v2/url?u=http-3A__pgxn.org&d=DwMFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=0TpvE_u2hS1ubQhK3gLhy94YgZm2k_r8JHJnqgjOXx4&m=6kA7Kpx0mAuAdk3FXOGfnKJThE55vL645cd0WmBT9IQ&s=pliFieJ3Zz7iab2EXRElsYDgw_HyCJu-ypSa3_QW8CY&e=>
>>>> bundle description)
>>>>
>>>>
>>>> Source repository: https://github.com/apache/datasketches-postgresql
>>>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_datasketches-2Dpostgresql&d=DwMFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=0TpvE_u2hS1ubQhK3gLhy94YgZm2k_r8JHJnqgjOXx4&m=6kA7Kpx0mAuAdk3FXOGfnKJThE55vL645cd0WmBT9IQ&s=ii0zSJTDjhqacoHpQR7rHVAPK88NG1lC0w4VmYSq6f4&e=>
>>>>
>>>>
>>>> Git tag for this release candidate:
>>>> https://github.com/apache/datasketches-postgresql/tree/1.4.0-rc2
>>>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_datasketches-2Dpostgresql_tree_1.4.0-2Drc2&d=DwMFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=0TpvE_u2hS1ubQhK3gLhy94YgZm2k_r8JHJnqgjOXx4&m=6kA7Kpx0mAuAdk3FXOGfnKJThE55vL645cd0WmBT9IQ&s=efKcdRJqjvC5i7b1y9j6ybApzqkZUBYHFXoZIcGYvjo&e=>
>>>>
>>>>
>>>> The release candidate repository:
>>>> https://dist.apache.org/repos/dist/dev/datasketches/postgresql/1.4.0-rc2
>>>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__dist.apache.org_repos_dist_dev_datasketches_postgresql_1.4.0-2Drc2&d=DwMFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=0TpvE_u2hS1ubQhK3gLhy94YgZm2k_r8JHJnqgjOXx4&m=6kA7Kpx0mAuAdk3FXOGfnKJThE55vL645cd0WmBT9IQ&s=A2AXNMepy89M0T5H8ATed33OcmIE8RqpsK-y6yJiP6A&e=>
>>>>
>>>>
>>>> How to build and install:
>>>> https://github.com/apache/datasketches-postgresql/blob/1.4.0-rc2/README.md
>>>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_datasketches-2Dpostgresql_blob_1.4.0-2Drc2_README.md&d=DwMFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=0TpvE_u2hS1ubQhK3gLhy94YgZm2k_r8JHJnqgjOXx4&m=6kA7Kpx0mAuAdk3FXOGfnKJThE55vL645cd0WmBT9IQ&s=_jrFKyLnqcg9_xEewWwekcMHdWs62k1gD99k4rl_3Ms&e=>
>>>>
>>>>
>>>> This vote will remain open for at least 72 hours and at least 3 (+1)
>>>> PMC votes or a majority of (+1) are acquired.
>>>>
>>>>
>>>> Please vote accordingly:
>>>>
>>>>
>>>> [ ] +1 approve
>>>>
>>>> [ ] +0 no opinion
>>>>
>>>> [ ] -1 disapprove with the reason
>>>>
>>>>
>>>> Thank you.
>>>>
>>>> Alexander Saydakov
>>>>
>>>> [email protected]
>>>>
>>>

Reply via email to